fix(rds): fix incorrect import/export combination check in AuroraMysqlEngineVersion.of() #33564
+2,648
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ysqlEngineVersion.of() Previously, `AuroraMysqlEngineVersion.of()` incorrectly determined whether import and export roles should be combined. This caused inconsistent behavior when specifying engine versions manually using `AuroraMysqlEngineVersion.of(...)`, leading to incorrect parameter settings in the DBClusterParameterGroup.
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
previously requested changes
Feb 23, 2025
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
1 task
…ysqlEngineVersion.of Previously, `AuroraMysqlEngineVersion.of()` incorrectly determined whether import and export roles should be combined. This caused inconsistent behavior when specifying engine versions manually using `AuroraMysqlEngineVersion.of(...)`, leading to incorrect parameter settings in the DBClusterParameterGroup.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, AuroraMysqlEngineVersion.of() incorrectly determined whether import and export roles should be combined.
This caused inconsistent behavior when specifying engine versions manually using AuroraMysqlEngineVersion.of(...), leading to incorrect parameter settings in the DBClusterParameterGroup.
Issue #33562
Closes #33562
Reason for this change
The issue arises when specifying a custom Aurora MySQL version using AuroraMysqlEngineVersion.of(...).
The logic for determining whether import and export roles should be combined is incorrect.
It should be based on the major version.
This bug causes s3ExportBuckets to configure DBClusterParameterGroup incorrectly:
Description of changes
If the major version is not "5.7", _combineImportAndExportRoles is set to true
Describe any new or updated permissions being added
None.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license