fix(cloudwatch): update regex expression that prevents CloudWatch:Mah:UnknownIdentifier warnings (#33591) #33592

garciparedes · 2025-02-26T16:26:18Z

Issue # (if applicable)

Closes #33591

Reason for this change

The validation is causing false-positive warning messages when using partial identifiers on CloudWatch Metric expressions supporting them.

Description of changes

Update the condition to generate the warning message in order to prevent false-positives when one of the special keywords is used.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

codecov · 2025-02-26T16:35:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (a21190e) to head (1d11712).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33592   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103

Flag	Coverage Δ
suite.unit	`82.21% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`82.21% <ø> (ø)`

garciparedes · 2025-02-26T16:59:21Z

Exemption Request: the pull request is updating a warning message so there is nothing to cover on integration tests.

packages/aws-cdk-lib/aws-cloudwatch/lib/metric.ts

…h:UnknownIdentifier warnings (aws#33591) Signed-off-by: Sergio García Prado <sergio@garciparedes.me>

GavinZZ

LGTM, thank you!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

mergify · 2025-02-28T23:18:54Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-03-01T00:17:39Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ validate-pr

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

garciparedes · 2025-03-03T08:44:02Z

@Mergifyio requeue

mergify · 2025-03-03T08:44:06Z

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

sender-permission >= write

Pull request has been modified.

garciparedes · 2025-03-03T08:46:20Z

Hey @GavinZZ, seems like the initial automated merge request failed for some reason. I updated the PR with the latest change. Could you try it again?

mergify · 2025-03-03T18:33:13Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-03-03T18:33:18Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify · 2025-03-03T18:37:31Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

GavinZZ · 2025-03-03T19:06:15Z

@Mergifyio requeue

mergify · 2025-03-03T19:06:41Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-03-03T19:07:17Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Pull request has been modified.

mergify · 2025-03-03T22:08:35Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-03-03T22:40:35Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-03-03T22:40:45Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation · 2025-03-03T22:40:45Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 1d11712
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

github-actions bot added bug p2 labels Feb 26, 2025

aws-cdk-automation requested a review from a team February 26, 2025 16:26

github-actions bot added the beginning-contributor label Feb 26, 2025

aws-cdk-automation previously requested changes Feb 26, 2025

View reviewed changes

garciparedes force-pushed the fix-cloudwatch-expression-warning branch 2 times, most recently from b3628d0 to b8f781e Compare February 26, 2025 16:50

aws-cdk-automation added the pr-linter/exemption-requested label Feb 26, 2025

github-advanced-security bot found potential problems Feb 26, 2025

View reviewed changes

packages/aws-cdk-lib/aws-cloudwatch/lib/metric.ts Fixed Show fixed Hide fixed

aws-cdk-automation added pr/needs-community-review labels Feb 26, 2025

garciparedes force-pushed the fix-cloudwatch-expression-warning branch from b8f781e to 10b2d29 Compare February 27, 2025 08:47

garciparedes requested a review from aws-cdk-automation February 27, 2025 09:32

garciparedes force-pushed the fix-cloudwatch-expression-warning branch from 10b2d29 to c4b93e7 Compare February 27, 2025 10:18

GavinZZ previously approved these changes Feb 28, 2025

View reviewed changes

GavinZZ added the pr-linter/exempt-integ-test label Feb 28, 2025

aws-cdk-automation removed the pr/needs-community-review label Feb 28, 2025

Merge branch 'main' into fix-cloudwatch-expression-warning

1c285aa

github-actions bot mentioned this pull request Mar 1, 2025

Monthly PR metrics report #33661

Open

Merge branch 'main' into fix-cloudwatch-expression-warning

7c986b1

aws-cdk-automation added the pr/needs-community-review label Mar 3, 2025

garciparedes requested a review from GavinZZ March 3, 2025 10:08

GavinZZ previously approved these changes Mar 3, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review label Mar 3, 2025

Merge branch 'main' into fix-cloudwatch-expression-warning

6f9c2de

aws-cdk-automation added the pr/needs-community-review label Mar 3, 2025

GavinZZ approved these changes Mar 3, 2025

View reviewed changes

Merge branch 'main' into fix-cloudwatch-expression-warning

1d11712

mergify bot merged commit 97744e7 into aws:main Mar 3, 2025
20 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cloudwatch): update regex expression that prevents CloudWatch:Mah:UnknownIdentifier warnings (#33591) #33592

fix(cloudwatch): update regex expression that prevents CloudWatch:Mah:UnknownIdentifier warnings (#33591) #33592

garciparedes commented Feb 26, 2025

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Feb 26, 2025 •

edited

Loading

garciparedes commented Feb 26, 2025

GavinZZ left a comment

mergify bot commented Feb 28, 2025

mergify bot commented Mar 1, 2025

garciparedes commented Mar 3, 2025

mergify bot commented Mar 3, 2025

garciparedes commented Mar 3, 2025

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

GavinZZ commented Mar 3, 2025

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

aws-cdk-automation commented Mar 3, 2025

fix(cloudwatch): update regex expression that prevents CloudWatch:Mah:UnknownIdentifier warnings (#33591) #33592

fix(cloudwatch): update regex expression that prevents CloudWatch:Mah:UnknownIdentifier warnings (#33591) #33592

Conversation

garciparedes commented Feb 26, 2025

Issue # (if applicable)

Reason for this change

Description of changes

Checklist

aws-cdk-automation left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Feb 26, 2025 • edited Loading

Codecov Report

garciparedes commented Feb 26, 2025

GavinZZ left a comment

Choose a reason for hiding this comment

mergify bot commented Feb 28, 2025

mergify bot commented Mar 1, 2025

garciparedes commented Mar 3, 2025

mergify bot commented Mar 3, 2025

❌ Command disallowed due to command restrictions in the Mergify configuration.

garciparedes commented Mar 3, 2025

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

GavinZZ commented Mar 3, 2025

mergify bot commented Mar 3, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

mergify bot commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

aws-cdk-automation commented Mar 3, 2025

AWS CodeBuild CI Report

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Feb 26, 2025 •

edited

Loading