Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-logs-destinations: Missing FirehoseDestination or DataFirehoseDestination #32038

Open
2 tasks
czechnology opened this issue Nov 6, 2024 · 2 comments · May be fixed by #33683
Open
2 tasks

aws-logs-destinations: Missing FirehoseDestination or DataFirehoseDestination #32038

czechnology opened this issue Nov 6, 2024 · 2 comments · May be fixed by #33683
Labels
@aws-cdk/aws-logs-destinations effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@czechnology
Copy link

Describe the feature

Currently, the aws_cdk.aws_logs_destinations package only contains KinesisDestination and LambdaDestination. However, logs subscriptions are possible also to Amazon Data Firehose, yet there seems to be no way to configure such subscription using CDK at the moment?

Use Case

I want to subscribe to CloudWatch Logs with Firehose as the destionation, as per this example in docs. My particular use case is forwarding of logs from CloudWatch to Dynatrace using Firehose.

Proposed Solution

Add a [Data]FirehoseDestination class to aws_logs_destinations.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.159.1

Environment details (OS name and version, etc.)

WSL2, Python 3.12
@czechnology czechnology added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 6, 2024
@ashishdhingra ashishdhingra self-assigned this Nov 6, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 6, 2024
@ashishdhingra
Copy link
Contributor

Valid feature request.

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 6, 2024
@ashishdhingra ashishdhingra removed their assignment Nov 6, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
@tomoki10
Copy link
Contributor

@ashishdhingra
I would like to implement this feature request and have already started working on it.
However, previous discussions concluded that they should use L2 Firehose, and the PR was closed.
#14918
Since L2 Firehose has remained in alpha for over 3 years, would it be acceptable to implement this for L1 Construct instead? Or should I implement it for the alpha version of L2 Construct?
Please advise on the best approach. Thanks.

This was referenced Mar 4, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-logs-destinations effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(logs-destinations): support Amazon Data Firehose logs destination Tietew/aws-cdk
3 participants
@czechnology @tomoki10 @ashishdhingra