-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-s3-deployment: Source.jsonData does not escape quotes #22661
Comments
Thanks for reporting this @revmischa, we should be sure account for these cases. I think we would need to do so in the private
|
Hi, I have successfully reproduce he issue by updating the integration test Here is the updated test:
And the actual failure:
|
Describe the bug
Doing something like
Where
replacementParams
contains an unresolved value, for example a secrets manager token in an SSM param, then that value will be interpolated into the JSON file without escaping quotes.e.g. if you make a secret:
Then you have to put that secret value into SSM (need to use SSM as a workaround for #21503) like
then the resulting S3 object will have
{"SECRET": "a21"vxC@29%9!"}
which is not valid JSONExpected Behavior
Escaped JSON
Current Behavior
Resolved token in SSM is not escaped when used as a JSON value in
Source.jsonData
Reproduction Steps
See above
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.39.1
Framework Version
No response
Node.js Version
16
OS
macos
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: