Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Cloudformation Badge Construct #4072

Open
2 tasks
jewelsjacobs opened this issue Sep 13, 2019 · 3 comments
Open
2 tasks

[Feature Request] Cloudformation Badge Construct #4072

jewelsjacobs opened this issue Sep 13, 2019 · 3 comments
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. needs-design This feature request needs additional design work. p2

Comments

@jewelsjacobs
Copy link

jewelsjacobs commented Sep 13, 2019

🚀 Feature Request

Dynamic Cloudformation Badge Construct

General Information

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Description

There is NOTHING more annoying than having to update the CodeBuild / CodePipeline status badge manually on a github project repo README.md. Nothing. JK. It is annoying though.

Wouldn't it be great if there was a CDK construct you could add to your Codebuild / Codepipeline stack and an easy svg url to put on a readme that could make this easier?

Proposed Solution

Although I don't have a solution for a construct this person actually wrote a CF template that does this: https://github.com/galaxy4public/aws-cloudformation-badges

Because it's a stack level component the CDK version would look something like this:

const app = new cdk.App();

const pipeline1 = new PipelineStack(app, 'Pipeline1', env );
const pipeline2 = new PipelineStack(app, 'Pipeline2', env );
const pipeline3 = new PipelineStack(app, 'Pipeline3', env );

const project1 = new ProjectStack(app, 'Project1', env );
const project2 = new ProjectStack(app, 'Project2', env );
const project3 = new ProjectStack(app, 'Project3', env );

// following the parameters from the CF template included in the sample project
new CloudformationBadges(this, 'MyStatusBadge', {
  projects: ['project1', 'project2'],
  pipelines: ['pipeline1', 'pipeline2'],
})

Maybe v1 could incorporate a single project / pipeline.

Environment

  • CDK CLI Version:
  • Module Version:
  • OS:
  • Language:

Other information

@jewelsjacobs jewelsjacobs added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 13, 2019
@NGL321 NGL321 added @aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-codepipeline Related to AWS CodePipeline status/needs-design and removed needs-triage This issue or PR still needs to be triaged. labels Sep 13, 2019
@NGL321 NGL321 self-assigned this Sep 13, 2019
@NGL321
Copy link
Contributor

NGL321 commented Sep 13, 2019

Hey @jewelsjacobs!

I really like this idea!
I am however, unsure of what the full scope of a construct for this would be.

Do you think it is something that could be integrated into the existing L2 constructs for Codebuild and Codepipeline, or is this something you are picturing as an independent construct?

😸

@jewelsjacobs
Copy link
Author

@NGL321 Unfortunately my real job has pulled me into all my cdk stuff and it makes it really hard to help out as much as I want to ☹️
Our construct / module needs, tooling, etc are diverging so much from what y'all are doing at this point that I can't share / contribute. If we start to "cross paths" again I'll join up!

@NGL321
Copy link
Contributor

NGL321 commented Oct 11, 2019

@jewelsjacobs
No worries! There is a lot of support for this request, so I'm sure it will get attention in the near future.
If its alright, I'll keep using this issue to track the feature.

😸

@NGL321 NGL321 assigned skinny85 and unassigned NGL321 Oct 11, 2019
@skinny85 skinny85 added the effort/large Large work item – several weeks of effort label Feb 6, 2020
@SomayaB SomayaB added needs-discussion This issue/PR requires more discussion with community. needs-design This feature request needs additional design work. and removed status/needs-design needs-discussion This issue/PR requires more discussion with community. labels Feb 25, 2020
@skinny85 skinny85 added the p2 label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. needs-design This feature request needs additional design work. p2
Projects
None yet
Development

No branches or pull requests

4 participants