-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cdk-pipelines/core] Give assets a display name #9628
Comments
@rix0rrr any updates on this issue? |
+1 feature request, this would be really useful |
+1 |
5 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue. |
+1 |
2 similar comments
+1 |
+1 |
ping... updates pls? |
+1 |
1 similar comment
+1 |
+1 |
1 similar comment
+1 |
I'd be happy to give implementing this a try. From looking at the code, this would require adding a new field to // In pipeline-graph.ts
// Inside PipelineGraph.publishAsset
const id = stackAsset.assetName ?? stackAsset.assetType === AssetType.FILE
? (this.singlePublisher ? 'FileAsset' : `FileAsset${++this._fileAssetCtr}`)
: (this.singlePublisher ? 'DockerAsset' : `DockerAsset${++this._dockerAssetCtr}`); As far as I can tell, this would require modifying the schemas in the Does this implementation plan sound reasonable? I'd like some feedback from more experienced people in this project. |
Please add? |
+1 |
+9 from my team. This would be quite nice! |
Another upvote from my team as well. |
+1 |
1 similar comment
+1 |
+1 looking to either hide the FileAsset in the pipeline or give meaningful names. If anyone knows how to do the former, it would help me a lot. Thanks |
+1 |
I might be misremembering but I read somewhere that the tasks in this repo get prioritised based on upvotes on the original (first) post (and not on the progression of the comments). So hopefully everyone +1-ing in the replies are also +1-ing the original post too. |
+1 |
8 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
1 similar comment
+1 |
I am working on the improvement of being able to process several assets in a deployment correcting the issue where several codebuilds are created one for each file, which complicates the pipelines, I leave the link of the branch with the correction, I'm still working on sending the PR, but it is functional. I hope it can help. https://github.com/eliecer2000/aws-cdk/tree/feat/pipeline-assets |
During
cdk deploy
and in the pipeline we now have no good way of showing the asset, just a hash.Much friendlier to users if we should show a display name.
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: