Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdk-pipelines/core] Give assets a display name #9628

Open
rix0rrr opened this issue Aug 12, 2020 · 43 comments
Open

[cdk-pipelines/core] Give assets a display name #9628

rix0rrr opened this issue Aug 12, 2020 · 43 comments
Assignees
Labels
@aws-cdk/core Related to core CDK functionality @aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 12, 2020

During cdk deploy and in the pipeline we now have no good way of showing the asset, just a hash.

Much friendlier to users if we should show a display name.


This is a 🚀 Feature Request

@rix0rrr rix0rrr added p2 @aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. effort/medium Medium work item – several days of effort @aws-cdk/pipelines CDK Pipelines library labels Aug 12, 2020
@rix0rrr rix0rrr added this to the [CDK Pipelines] Soon milestone Aug 12, 2020
@eladb eladb removed their assignment Aug 17, 2020
@rix0rrr rix0rrr removed this from the [GA] CDK Pipelines milestone Jan 7, 2021
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@bobmoff
Copy link

bobmoff commented Oct 21, 2021

Did this feature die ?

It is a bit confusing to have this..
CleanShot 2021-10-21 at 15 05 27

.. would be awesome to be able to add display name.

@bodokaiser
Copy link

@rix0rrr any updates on this issue?

@pfried
Copy link

pfried commented Feb 22, 2022

image

Is there any way (right now) to get better file asset naming?

@clairemr
Copy link
Contributor

clairemr commented Mar 7, 2022

+1 feature request, this would be really useful

@sonnenhaft
Copy link

+1

5 similar comments
@jordanivy
Copy link

+1

@martijnburger
Copy link

+1

@droewe-reply
Copy link

+1

@SQPferrer
Copy link

+1

@siggi84
Copy link

siggi84 commented Sep 1, 2022

+1

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue.

@github-actions github-actions bot added p1 and removed p2 labels Sep 4, 2022
@KevinToala
Copy link

+1

2 similar comments
@thedevopsguyblog
Copy link

+1

@jvjfranca
Copy link

+1

@ustulation
Copy link

ping... updates pls?

@joshdirkx
Copy link

+1

1 similar comment
@mccauleyp
Copy link

+1

@sgates
Copy link

sgates commented Mar 2, 2023

+1

1 similar comment
@roey-navina
Copy link

+1

@danno-s
Copy link

danno-s commented Mar 15, 2023

I'd be happy to give implementing this a try. From looking at the code, this would require adding a new field to StackAsset to contain a user-defined name and setting the pipeline's graph node id to it. Something like this:

// In pipeline-graph.ts
// Inside PipelineGraph.publishAsset
const id = stackAsset.assetName ?? stackAsset.assetType === AssetType.FILE
        ? (this.singlePublisher ? 'FileAsset' : `FileAsset${++this._fileAssetCtr}`)
        : (this.singlePublisher ? 'DockerAsset' : `DockerAsset${++this._dockerAssetCtr}`);

As far as I can tell, this would require modifying the schemas in the cloud-assembly-schema package and persisting these names in the asset manifest. With those then we can use them to populate the new field in the StackAsset. However I haven't been able to find where the manifest objects are built before they are persisted.

Does this implementation plan sound reasonable? I'd like some feedback from more experienced people in this project.

@nick-benyo
Copy link

Please add?

@eliecer2000
Copy link

image

Is there any way (right now) to get better file asset naming?

Is it possible to group codebuild projects into one?

I say this because I would like a single project that is sending the assets file.

thank you,

@Chrisjw42
Copy link

+1

@Belair34
Copy link

Belair34 commented Jun 9, 2023

+9 from my team. This would be quite nice!

@davidmjames
Copy link

Another upvote from my team as well.

@avishmehta
Copy link

+1

1 similar comment
@jcorey-envative
Copy link

+1

@dinesh-madhav
Copy link

+1 looking to either hide the FileAsset in the pipeline or give meaningful names. If anyone knows how to do the former, it would help me a lot. Thanks

@ilyash-b
Copy link

+1

@ustulation
Copy link

I might be misremembering but I read somewhere that the tasks in this repo get prioritised based on upvotes on the original (first) post (and not on the progression of the comments). So hopefully everyone +1-ing in the replies are also +1-ing the original post too.

@craigbroadman
Copy link

+1

8 similar comments
@hakimbho
Copy link

hakimbho commented Nov 3, 2023

+1

@enheit
Copy link

enheit commented Jan 29, 2024

+1

@ozerbiber
Copy link

+1

@RickKrause
Copy link

+1

@melgard
Copy link

melgard commented Sep 19, 2024

+1

@LawrenceStanton
Copy link

+1

@yasas-mintpay
Copy link

+1

@codyataiphone
Copy link

+1

@yasas-mintpay
Copy link

+1

1 similar comment
@devrivne
Copy link

+1

@eliecer2000
Copy link

image

Is there any way (right now) to get better file asset naming?

I am working on the improvement of being able to process several assets in a deployment correcting the issue where several codebuilds are created one for each file, which complicates the pipelines, I leave the link of the branch with the correction, I'm still working on sending the PR, but it is functional. I hope it can help.

https://github.com/eliecer2000/aws-cdk/tree/feat/pipeline-assets

@jiayiwang7
Copy link
Member

aws/aws-cdk-cli#175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality @aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.