-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipelines): display names can be set for assets in a pipeline #24917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
11 similar comments
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
1 similar comment
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
…/aws-cdk into named-assets-in-pipeline
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
This change enables users to set display names for assets in their pipelines, to make Asset steps in CodePipeline easier to parse. Instead of having 'FileAssetN' and 'DockerAssetN' actions in these steps, users could have descriptive names for these assets like 'GetProfile' or 'AddToCart'.
For a user, this would consist of using the new
displayName
properties in theAsset
,TarballImageAsset
andDockerImageAsset
constructs, like so:Implementation of this feature involves following the whole lifecycle of an asset. From the moment of instantiation to the generation of manifests and later parsing these manifests while building the pipeline. To avoid changing method signatures I opted to add a new optional property
displayName
in theFileSource
andDockerImageSource
interfaces. This property is passed all the way down to theAssetManifestBuilder
, where it's persisted into the file manifest.This required modifying the schema of the asset manifest. AFAIK, this change can not be implemented without adding information to it. The only possible spot for this display name without changing the schema would be in an asset's key, which normally is a hash and may be used by other methods to detect wether the asset should be reuploaded.
This feature includes changes to the
aws-s3-assets
andaws-ecr-assets
to enable passing of thedisplayName
property to them. Higher level constructs (likeNodejsLambda
) will require some wiring to pass these same properties lower into the tree to their used 'base types' (Asset
,TarballImageAsset
andDockerImageAsset
). I might include this use case into the PR before finishing the draft.TODO:
Closes #9628.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license