feat(stepfunctions-tasks): bedrock createModelCustomizationJob integration

[badmintoncryer]

This PR was previously created and passed the community review, but the maintainer review stopped midway, and it was eventually closed. There shouldn’t be any issues with the content, so I am submitting the PR again.

Issue # (if applicable)

Closes #29042

Reason for this change

AWS stepfunctions support optimized integration with AWS bedrock.
Currently, only invokeModel is supported by CDK, but I would like createModelCustomizationJob to be supported in the same manner.

Description of changes

I've added CreatemodelCustomizationJob class.

const taskConfig = {
  baseModel: model,
  clientRequestToken: 'MyToken',
  customizationType: CustomizationType.FINE_TUNING,
  kmsKey,
  customModelName: 'MyCustomModel',
  customModelTags: [{ key: 'key1', value: 'value1' }],
  hyperParameters: {
    batchSize: '10',
  },
  jobName: 'MyCustomizationJob',
  jobTags: [{ key: 'key2', value: 'value2' }],
  outputDataS3Uri: outputBucket.s3UrlForObject(),
  trainingDataS3Uri: trainingBucket.s3UrlForObject(),
  validationDataS3Uri: [validationBucket.s3UrlForObject()],
  vpcConfig: {
    securityGroups: [new ec2.SecurityGroup(stack, 'SecurityGroup', { vpc })],
    subnets: vpc.isolatedSubnets,
  },
};

const task1 = new BedrockCreateModelCustomizationJob(stack, 'CreateModelCustomizationJob1', taskConfig);

const chain = sfn.Chain
  .start(new sfn.Pass(stack, 'Start'))
  .next(task1)
  .next(new sfn.Pass(stack, 'Done'));

new sfn.StateMachine(stack, 'StateMachine', {
  definitionBody: sfn.DefinitionBody.fromChainable(chain),
  timeout: cdk.Duration.seconds(30),
});

Description of how you validated changes

I've added both unit and integ tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[badmintoncryer]

@gracelu0 I'm really sorry for my late response. I've addressed all of your comments. Could you please reconfirm again?

[5d]

Avoid using the I prefix for interface names unless the interface is specifically intended to represent behavior. Reference: jsii Specification – Interfaces vs Structs

[5d]

Additionally, the interface name is too generic. It would be better to either place it within a relevant namespace or give it a more descriptive name.

[badmintoncryer]

I've updated to CustomModelTag.

[5d]

It's important to note that addToResourcePolicy has no effect when used on a KMS key imported via fromKeyArn.

Reference: aws-cdk-lib/aws-kms/key.ts#L163.

It's recommended to check the return value of the method to ensure the policy was actually applied.

[badmintoncryer]

Which is better to throw error or show warnings when customModelKmsKey is imported key? For now, I have implemented it to display warnings.

if (this.props.customModelKmsKey) {
      const poliyStatement = new iam.PolicyStatement({
        actions: ['kms:Decrypt', 'kms:GenerateDataKey', 'kms:DescribeKey', 'kms:CreateGrant'],
        resources: ['*'],
        principals: [new iam.ArnPrincipal(this._role.roleArn)],
        conditions: {
          StringEquals: {
            'kms:ViaService': [
              `bedrock.${Stack.of(this).region}.amazonaws.com`,
            ],
          },
        },
      });
      const result = this.props.customModelKmsKey.addToResourcePolicy(poliyStatement, true);

      // For the imported key, user must add the policy statement to the key policy
      if (result.statementAdded === false) {
        Annotations.of(this).addWarning(`You must update 'customModelKmsKey' resource policy to add the following statement:
        ${poliyStatement.toString()}`);
      }
    }

[5d]

Thanks for updating the PR. I haven’t worked with this Bedrock job much before, but here’s my take: if missing permissions on the KMS key ultimately cause the job to fail, we should throw an exception to follow the fail-fast principle. On the other hand, if the lack of permission doesn’t block the job from running, then a warning message should suffice.

[badmintoncryer]

Sure. I've updated the implementation to throw an error.

[5d]

LGTM, could you help me resolve the build errors of unused imports?

[badmintoncryer]

@5d Thank you for your review!! I've addressed your comments.

[5d]

LGTM, thanks for your effort on this!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: fcf5b01
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.