feat(eks): Nodegroup support nodeRepairConfig
#32626
Conversation
github-actions
bot
added
repeat-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
phuhung273
changed the title
nodeRepairConfigNodegroup support nodeRepairConfig
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32626 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6937 6937
Branches 1170 1170
=======================================
Hits 5715 5715
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
aws-cdk-automation
added
the
pr/needs-community-review
| new integ.IntegTest(app, 'aws-cdk-eks-nodegroup-repair-config', { | ||
| testCases: [stack], | ||
| // Test includes assets that are updated weekly. If not disabled, the upgrade PR will fail. | ||
| diffAssets: false, | ||
| }); |
There was a problem hiding this comment.
nit: any assertions we can add?
There was a problem hiding this comment.
I did try to. But seems like something wrong with EKS DescribeNodegroup API.
{
"nodegroup": {
"amiType": "AL2023_x86_64_STANDARD",
"capacityType": "ON_DEMAND",
"clusterName": "Cluster9EE0221C-36a4e31332254b13b24d08339cdfa144",
"createdAt": "2025-02-14T01:27:04.073Z",
"diskSize": 20,
"health": {
"issues": []
},
"instanceTypes": [
"t3.micro"
],
"labels": {},
"modifiedAt": "2025-02-14T01:28:44.250Z",
"nodeRole": "arn:aws:iam::<MY_ACCOUNT>:role/aws-cdk-eks-nodegroup-rep-ClusterNodegroupMNGAL2023-tVMCbaTW4nBh",
"nodegroupArn": "arn:aws:eks:us-east-1:<MY_ACCOUNT>:nodegroup/Cluster9EE0221C-36a4e31332254b13b24d08339cdfa144/ClusterNodegroupMNGAL2023X8-yU4tahg9bhFu/a4ca8108-7f41-618c-4ad4-e50d6b9accf8",
"nodegroupName": "ClusterNodegroupMNGAL2023X8-yU4tahg9bhFu",
"releaseVersion": "1.31.4-20250203",
"resources": {
"autoScalingGroups": [
{
"name": "eks-ClusterNodegroupMNGAL2023X8-yU4tahg9bhFu-a4ca8108-7f41-618c-4ad4-e50d6b9accf8"
}
]
},
"scalingConfig": {
"minSize": 1,
"maxSize": 2,
"desiredSize": 2
},
"status": "ACTIVE",
"subnets": [
"subnet-097df13eb8cffc6bd",
"subnet-0578a7502899d27c8"
],
"tags": {
"aws:cloudformation:stack-id": "arn:aws:cloudformation:us-east-1:<MY_ACCOUNT>:stack/aws-cdk-eks-nodegroup-repair-config-test/e3f1b500-ea70-11ef-9c66-0e98b891b35b",
"aws:cloudformation:stack-name": "aws-cdk-eks-nodegroup-repair-config-test",
"aws:cloudformation:logical-id": "ClusterNodegroupMNGAL2023X8664STANDARD8BD0F7AB"
},
"updateConfig": {
"maxUnavailable": 1
},
"version": "1.31"
}
}It doesn't have nodeRepairConfig as advertised in https://docs.aws.amazon.com/eks/latest/APIReference/API_DescribeNodegroup.html
Is it ok if we just assert status: Active ?
| /** | ||
| * The node auto repair configuration for the node group. | ||
| * | ||
| * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-eks-nodegroup-noderepairconfig.html |
There was a problem hiding this comment.
nit: I think this doc explains node repair config better
| * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-eks-nodegroup-noderepairconfig.html | ||
| * @default - disabled | ||
| */ | ||
| readonly nodeRepairConfig?: NodegroupRepairConfig; |
There was a problem hiding this comment.
We don't enforce this CDK wide but I think in this case the property should be
readonly nodeRepairConfig?: boolean;
Reason is I don't suspect there will be any additional properties added to the NodegroupRepairConfig, you either enable auto repair or you don't, there's not much configuration you can add to that. So I'd prefer to make the property boolean and have one less interface.
| @@ -333,6 +345,14 @@ export interface NodegroupOptions { | |||
| * @default undefined - node groups will update instances one at a time | |||
| */ | |||
| readonly maxUnavailablePercentage?: number; | |||
|
|
|||
There was a problem hiding this comment.
thanks for adding it to both modules!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32562
Description of changes
nodeRepairConfigChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license