Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(applicationsignals-alpha): introduce Application Signals L2 constructs #32931

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bjrara
Copy link

@bjrara bjrara commented Jan 15, 2025

Issue # (if applicable)

N/A

Description of changes

This PR adds L2 constructs to simplify the Application Signals enablement process. See aws/aws-cdk-rfcs#672 for more details.

Describe any new or updated permissions being added

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2025 01:52
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@bjrara bjrara changed the title feat(aws-applicationsignals-alpha): introduce Application Signals L2 constructs feat(applicationsignals-alpha): introduce Application Signals L2 constructs Jan 15, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 15, 2025 01:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6e0aa13). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32931   +/-   ##
=======================================
  Coverage        ?   82.37%           
=======================================
  Files           ?      120           
  Lines           ?     6933           
  Branches        ?     1169           
=======================================
  Hits            ?     5711           
  Misses          ?     1119           
  Partials        ?      103           
Flag Coverage Δ
suite.unit 82.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (?)
packages/aws-cdk-lib/core 82.37% <ø> (?)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjrara bjrara force-pushed the application-signals branch 5 times, most recently from 921a486 to 43766a8 Compare January 15, 2025 04:42
@aws aws deleted a comment from aws-cdk-automation Jan 15, 2025
@moelasmar
Copy link
Contributor

moelasmar commented Jan 16, 2025

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jan 16, 2025

refresh

✅ Pull request refreshed

@bjrara bjrara force-pushed the application-signals branch 2 times, most recently from 652b1da to 021dcf9 Compare January 20, 2025 18:16
throw new Error('Fargate tasks must deploy CloudWatch Agent as a sidecar container');
}
if (cloudWatchAgentConfig.enableSidecar) {
props.taskDefinition.taskRole.addManagedPolicy(ManagedPolicy.fromAwsManagedPolicyName('CloudWatchAgentServerPolicy'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using this Managed policy violates the Apply least-privilege permissions rule of the security best practices, since as defined here, this managed policy enable multiple actions for * resources. It will be petter to add a new Policy, and add the specific resources that you need these actions to be allowed on them.

@bjrara bjrara force-pushed the application-signals branch from 021dcf9 to 6a0863c Compare January 22, 2025 04:19
@mergify mergify bot dismissed moelasmar’s stale review January 22, 2025 04:20

Pull request has been modified.

@bjrara bjrara force-pushed the application-signals branch 3 times, most recently from 5a2f537 to f8b8fa2 Compare January 22, 2025 07:34
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 7 days if no action is taken.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Feb 21, 2025
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
@aws aws unlocked this conversation Feb 23, 2025
@moelasmar moelasmar reopened this Feb 23, 2025
@moelasmar
Copy link
Contributor

@bjrara .. are you planning to finalize this PR ?

@bjrara
Copy link
Author

bjrara commented Feb 24, 2025

@bjrara .. are you planning to finalize this PR ?

Yes.

@bjrara bjrara force-pushed the application-signals branch 3 times, most recently from bb1e7ce to 612770e Compare February 26, 2025 19:02
@QuantumNeuralCoder QuantumNeuralCoder removed the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Feb 26, 2025
@bjrara bjrara force-pushed the application-signals branch from 612770e to 53bb7d4 Compare March 10, 2025 19:24
@bjrara bjrara force-pushed the application-signals branch from 53bb7d4 to 54b6c75 Compare March 11, 2025 00:02
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 54b6c75
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@bjrara
Copy link
Author

bjrara commented Mar 13, 2025

All the major comments are addressed. Only two comments to add additional document link for used environment variables are left open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants