chore: add undefined type to principalAccount

[dali546]

Reason for this change

When using TypeScript option exactOptionalPropertyTypes: truewe get the following error. All implementations ofIPrincipalhave the typestring | undefined` so this is change will apply it at the base

Type 'AccountPrincipal' is not assignable to type 'IPrincipal' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
  Types of property 'principalAccount' are incompatible.
    Type 'string | undefined' is not assignable to type 'string'.
      Type 'undefined' is not assignable to type 'string'.ts(2375)

Description of changes

Changed type definition of IPrincipal principalAccount

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (b48a5ad) to head (147ad14).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33055   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files         120      120           
  Lines        6933     6933           
  Branches     1169     1169           
=======================================
  Hits         5711     5711           
  Misses       1119     1119           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.37% <ø> (ø)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lpizzinidev]

Hi @dali546 ✋
It seems that this PR raised a similar issue a while ago. The related discussion is still open.
I guess that general guidance should be provided for type declarations of | undefined / ?: props.
@kaizencc Thoughts?

[GavinZZ]

@lpizzinidev @dali546 thanks for the PR. I added some new update in the discussion post #23885 (comment).

Can you let me know your use case of the IPrincipal variable and if you can use the workaround mentioned. I'm happy to have this merged if the workaround mentioned does not work for you.

[dali546]

@GavinZZ the use case is even just creating simple roles using a principal, it causes the error eg

    const role = new Role(this, "role", {
      assumedBy: new WebIdentityPrincipal("accounts.google.com", {}),
    });

Type 'WebIdentityPrincipal' is not assignable to type 'IPrincipal' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
  Types of property 'principalAccount' are incompatible.
    Type 'string | undefined' is not assignable to type 'string'.
      Type 'undefined' is not assignable to type 'string'.ts(2375)

The proposed workaround of using the spread operator doesn't help here either because principalAccount? is defined inside WebIdentityPrincipal

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 1878259
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.