Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamodb): fix addToResourcePolicy not adding any statements to the resource policy #33275

Closed
wants to merge 5 commits into from

Conversation

xonstone
Copy link

@xonstone xonstone commented Feb 3, 2025

Issue # (if applicable)

Closes #30793.

Reason for this change

addToResourcePolicy has no effect on changesets.

Description of changes

Made this.resourcePolicy the target for synthesizing instead of props.resourcePolicy

Describe any new or updated permissions being added

NA

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@xonstone xonstone requested a review from a team as a code owner February 3, 2025 14:59
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 3, 2025 14:59
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Feb 3, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@xonstone xonstone changed the title Draft: Fix addToResourcePolicy in aws-dynamodb fix(aws-dynamodb): Fix addToResourcePolicy in aws-dynamodb Feb 3, 2025
@xonstone xonstone changed the title fix(aws-dynamodb): Fix addToResourcePolicy in aws-dynamodb fix(aws-dynamodb): Fix addToResourcePolicy Feb 3, 2025
@xonstone xonstone changed the title fix(aws-dynamodb): Fix addToResourcePolicy fix(aws-dynamodb): fix addToResourcePolicy not adding any statements to the resource policy Feb 3, 2025
@xonstone xonstone changed the title fix(aws-dynamodb): fix addToResourcePolicy not adding any statements to the resource policy fix(dynamodb): fix addToResourcePolicy not adding any statements to the resource policy Feb 3, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4c97746
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Mar 12, 2025
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-dynamodb: addToResourcePolicy has no effect
2 participants