-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codepipeline-actions): support ECRBuildAndPublish
action
#33375
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33375 +/- ##
==========================================
+ Coverage 80.92% 81.00% +0.07%
==========================================
Files 236 238 +2
Lines 14256 14271 +15
Branches 2491 2492 +1
==========================================
+ Hits 11537 11560 +23
+ Misses 2434 2425 -9
- Partials 285 286 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ECRBuildAndPublish
action
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ CodeCov is indicating a drop in code coverage
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
Exemption Request:
Should already have written unit tests that cover the code I have added. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #33376
Reason for this change
AWS CodePipeline introduces new build action: ECRBuildAndPublish action.
Description of changes
Add
ECRBuildAndPublishAction
class that extendsAction
class to aws-codepipeline-actions module.Describe any new or updated permissions being added
Description of how you validated changes
Both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license