Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codepipeline-actions): support ECRBuildAndPublish action #33375

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Feb 11, 2025

Issue # (if applicable)

Closes #33376

Reason for this change

AWS CodePipeline introduces new build action: ECRBuildAndPublish action.

Description of changes

Add ECRBuildAndPublishAction class that extends Action class to aws-codepipeline-actions module.

Describe any new or updated permissions being added

Description of how you validated changes

Both unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2025 07:23
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Feb 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (c400e0e) to head (0f824ed).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33375      +/-   ##
==========================================
+ Coverage   80.92%   81.00%   +0.07%     
==========================================
  Files         236      238       +2     
  Lines       14256    14271      +15     
  Branches     2491     2492       +1     
==========================================
+ Hits        11537    11560      +23     
+ Misses       2434     2425       -9     
- Partials      285      286       +1     
Flag Coverage Δ
suite.unit 81.00% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.92% <ø> (+0.18%) ⬆️
packages/aws-cdk-lib/core 82.16% <ø> (-0.05%) ⬇️

@github-actions github-actions bot added the feature-request A feature should be added or improved. label Feb 11, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): support ECRBuildAndPublish build action feat(codepipeline-actions): support ECRBuildAndPublish action Feb 11, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): support ECRBuildAndPublish action feat(codepipeline-actions): support ECRBuildAndPublish action Feb 11, 2025
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Feb 14, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 14, 2025 13:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@go-to-k go-to-k marked this pull request as ready for review February 14, 2025 13:57
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 14, 2025 14:40

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ CodeCov is indicating a drop in code coverage

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@go-to-k
Copy link
Contributor Author

go-to-k commented Feb 14, 2025

Exemption Request:

❌ CodeCov is indicating a drop in code coverage

Should already have written unit tests that cover the code I have added.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Feb 14, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0f824ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 14, 2025
@GavinZZ GavinZZ self-assigned this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codepipeline-actions: support ECRBuildAndPublish action
3 participants