-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): allow to specify availability zone for Aurora instances #33515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33515 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6937 6937
Branches 1170 1170
=======================================
Hits 5715 5715
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Just one small nit that I think would make the integration test a little more readable for the future.
With respect to the README changes, we should include an example of the new property to showcase how it's expected to be used. Please include it either in a new section in the README, or in one of the existing examples. Thank you!
packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster-availability-zone.ts
Outdated
Show resolved
Hide resolved
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
@Leo10Gama |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, changes LGTM! Thanks again for your contribution!
@Mergifyio update |
✅ Branch has been successfully updated |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #33503.
Closes #30618.
Reason for this change
When creating a single-zone Aurora cluster and an EC2 instance in development purpose, I want to pin the Aurora instance and the EC2 instance in a same availability zone.
We can specify
AvailabilityZone
in Aurora'sAWS::RDS::DBInstance
as same as standalone RDS instances.Description of changes
Added
availabilityZone
prop inClusterInstanceOptions
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Unit test and integ test.
The integ test also verifies created instances are placed in expected availability zone.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license