feat(msk-alpha): add brokerEndpoints property on cluster #33547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Currently only some broker endpoints are retrievable;
While the BootstrapBrokers API can return many more.
The CustomResource used to fetch the brokers also use the first fetched
responseField
in the logical id;This means just changing the order, changes the logical id. Which isn't a breaking change as I understand, but a somewhat unnecessary behavioral change.
Description of changes
Introduced
brokerEndpoints
property which uses a custom resource to retrieve all bootstrap broker endpoints.Keep old API for full backwards compability, but should probably be deprecated in the future.
Description of how you validated changes
Unit tests not really applicable.
Deploying minimal stacks and using cloudformation exports to export several various broker endpoints depending on cluster setup.
Updated integrations tests but can not run them unfortunately.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license