-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert unintended snapshot changes due to feature flags #33616
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33616 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 119 119
Lines 6876 6876
Branches 1162 1162
=======================================
Hits 5653 5653
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Looks good to me. For the title, it will be included in the revert section of releasing note. Is that intended or should we change it to chore? |
Updated to 'chore' so that it doesn't show up in the change log |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
#33291
This PR incorrectly updates integration test snapshots without introducing new feature flags. This is causing some issues with local integration test because in local, we expect new feature flag to be default off while in CI, it's expected to be default to true.
Description of changes
Revert back snapshot changes
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Tests pass
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license