chore(ec2): backfill missing enums for ec2 #33642
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33642 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 119 119
Lines 6876 6876
Branches 1162 1162
=======================================
Hits 5653 5653
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
|
||
| /** | ||
| * i386 architecture | ||
| */ | ||
| I386 = 'i386', | ||
|
|
||
| /** | ||
| * x86-64 architecture for Mac | ||
| */ | ||
| X86_64_MAC = 'x86_64_mac', | ||
|
|
||
| /** | ||
| * arm64 architecture for Mac | ||
| */ | ||
| ARM64_MAC = 'arm64_mac', |
There was a problem hiding this comment.
Not a valid value for the property as per the CFN doc
| /** | ||
| * The instance will hibernate when it initiates a shutdown. | ||
| */ | ||
| HIBERNATE = 'hibernate', |
There was a problem hiding this comment.
Not a valid value for the property as per the CFN doc
|
|
||
| /** | ||
| * i386 CPU type | ||
| */ | ||
| I386 = 'i386', | ||
|
|
||
| /** | ||
| * x86-64 CPU type for Mac | ||
| */ | ||
| X86_64_MAC = 'x86_64_mac', | ||
|
|
||
| /** | ||
| * arm64 CPU type for Mac | ||
| */ | ||
| ARM64_MAC = 'arm64_mac', |
There was a problem hiding this comment.
Not sure if these are valid values for the enum. Couldn't able to find corresponding doc to validate.
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Description of changes
backfill missing enums for ec2
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license