-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ec2): backfill missing enums for ec2 #33642
Changes from all commits
09bb1e2
66af285
92ca223
4bcba5e
45cce36
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,11 @@ export enum InstanceInitiatedShutdownBehavior { | |
* The instance will be terminated when it initiates a shutdown. | ||
*/ | ||
TERMINATE = 'terminate', | ||
|
||
/** | ||
* The instance will hibernate when it initiates a shutdown. | ||
*/ | ||
HIBERNATE = 'hibernate', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a valid value for the property as per the CFN doc |
||
} | ||
|
||
/** | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -163,6 +163,21 @@ export enum AmazonLinuxCpuType { | |
* x86_64 CPU type | ||
*/ | ||
X86_64 = 'x86_64', | ||
|
||
/** | ||
* i386 CPU type | ||
*/ | ||
I386 = 'i386', | ||
|
||
/** | ||
* x86-64 CPU type for Mac | ||
*/ | ||
X86_64_MAC = 'x86_64_mac', | ||
|
||
/** | ||
* arm64 CPU type for Mac | ||
*/ | ||
ARM64_MAC = 'arm64_mac', | ||
Comment on lines
+166
to
+180
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if these are valid values for the enum. Couldn't able to find corresponding doc to validate. |
||
} | ||
|
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a valid value for the property as per the CFN doc
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html#cfn-ec2-instance-instancetype