Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): backfill missing enums for ecs #33644

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −0
Open

feat(ecs): backfill missing enums for ecs #33644

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67497f5
chore(ecs): backfill missing enums for ecs
paulhcsun Feb 28, 2025
2662f1e
Update packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
Leo10Gama Mar 1, 2025
9f8a6d8
Update packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
paulhcsun Mar 12, 2025
c06ad15
Merge branch 'main' into backfill-enums/ecs
paulhcsun Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(ecs): backfill missing enums for ecs
  • Loading branch information
@paulhcsun
paulhcsun committed Feb 28, 2025
commit 67497f57fb4d6ab8056bc7247f8e528b03e29d92
8 changes: 8 additions & 0 deletions packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts
View file
Original file line number Diff line number Diff line change
@@ -165,6 +165,10 @@ export enum FileSystemType {
* xfs type
*/
XFS = 'xfs',
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
NTFS = 'ntfs',
}

/**
@@ -179,6 +183,10 @@ export enum EbsPropagatedTagSource {
* TASK_DEFINITION
*/
TASK_DEFINITION = 'TASK_DEFINITION',
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
NONE = 'NONE',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
NONE = 'NONE',

I think this is another enum value that may not be necessary given the situation, but I'm not 100% familiar with ECS. Worth investigating this instance before approving as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a valid value according to CFN docs here

}

/**
Loading
Oops, something went wrong.