chore(eks): backfill missing enums for eks #33646
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33646 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 119 119
Lines 6876 6876
Branches 1162 1162
=======================================
Hits 5653 5653
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Leo10Gama
reviewed
Mar 1, 2025
Comment on lines
+110
to
+113
| /** | ||
| * [PLACEHOLDER FOR: TO BE FILLED OUT] | ||
| */ | ||
| CAPACITY_BLOCK = 'CAPACITY_BLOCK', |
There was a problem hiding this comment.
Suggested change
| /** | |
| * [PLACEHOLDER FOR: TO BE FILLED OUT] | |
| */ | |
| CAPACITY_BLOCK = 'CAPACITY_BLOCK', |
This may be an error in the tool, since this seems like the generic name for it rather than the type itself. Worth investigating before committing here.
Comment on lines
+92
to
+95
| /** | ||
| * [PLACEHOLDER FOR: TO BE FILLED OUT] | ||
| */ | ||
| CUSTOM = 'CUSTOM', |
There was a problem hiding this comment.
Suggested change
| /** | |
| * [PLACEHOLDER FOR: TO BE FILLED OUT] | |
| */ | |
| CUSTOM = 'CUSTOM', |
I'm not sure if CDK currently supports custom nodegroup types, and if we don't I think adding this enum value would be irresponsible, since it may lead to the impression that we do support it.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
backfill missing enums for eks
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license