-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eks): backfill missing enums for eks #33646
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33646 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 119 119
Lines 6876 6876
Branches 1162 1162
=======================================
Hits 5653 5653
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/** | ||
* [PLACEHOLDER FOR: TO BE FILLED OUT] | ||
*/ | ||
CAPACITY_BLOCK = 'CAPACITY_BLOCK', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* [PLACEHOLDER FOR: TO BE FILLED OUT] | |
*/ | |
CAPACITY_BLOCK = 'CAPACITY_BLOCK', |
This may be an error in the tool, since this seems like the generic name for it rather than the type itself. Worth investigating before committing here.
/** | ||
* [PLACEHOLDER FOR: TO BE FILLED OUT] | ||
*/ | ||
CUSTOM = 'CUSTOM', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* [PLACEHOLDER FOR: TO BE FILLED OUT] | |
*/ | |
CUSTOM = 'CUSTOM', |
I'm not sure if CDK currently supports custom nodegroup types, and if we don't I think adding this enum value would be irresponsible, since it may lead to the impression that we do support it.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Description of changes
backfill missing enums for eks
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license