Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): backfill missing enums for eks #33646

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(eks): backfill missing enums for eks #33646

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27758f2
chore(eks): backfill missing enums for eks
paulhcsun Feb 28, 2025
3550a94
Merge branch 'main' into backfill-enums/eks
paulhcsun Mar 1, 2025
5edd7d2
Update packages/aws-cdk-lib/aws-eks/lib/managed-nodegroup.ts
paulhcsun Mar 12, 2025
cc72b8f
Update packages/aws-cdk-lib/aws-eks/lib/managed-nodegroup.ts
paulhcsun Mar 12, 2025
8617505
Merge branch 'main' into backfill-enums/eks
paulhcsun Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(eks): backfill missing enums for eks
  • Loading branch information
@paulhcsun
paulhcsun committed Feb 28, 2025
commit 27758f24e2f2bacc1dcaa4cf5c7fa022856f1594
8 changes: 8 additions & 0 deletions packages/aws-cdk-lib/aws-eks/lib/managed-nodegroup.ts
View file
Original file line number Diff line number Diff line change
@@ -89,6 +89,10 @@ export enum NodegroupAmiType {
* Amazon Linux 2023 (ARM-64)
*/
AL2023_ARM_64_STANDARD = 'AL2023_ARM_64_STANDARD',
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
CUSTOM = 'CUSTOM',
}

/**
@@ -103,6 +107,10 @@ export enum CapacityType {
* on-demand instances
*/
ON_DEMAND = 'ON_DEMAND',
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
CAPACITY_BLOCK = 'CAPACITY_BLOCK',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* [PLACEHOLDER FOR: TO BE FILLED OUT]
*/
CAPACITY_BLOCK = 'CAPACITY_BLOCK',

This may be an error in the tool, since this seems like the generic name for it rather than the type itself. Worth investigating before committing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid value according to CFN docs: https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html

}

/**
Loading
Oops, something went wrong.