Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(s3): backfill missing enums for s3 #33655

Merged
merged 4 commits into from
Mar 4, 2025
Merged

chore(s3): backfill missing enums for s3 #33655

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d87fe87
chore(s3): backfill missing enums for s3
paulhcsun Feb 28, 2025
71cf4c2
Update packages/aws-cdk-lib/aws-s3/lib/bucket.ts
paulhcsun Mar 1, 2025
1d72c57
Update packages/aws-cdk-lib/aws-s3/lib/bucket.ts
paulhcsun Mar 1, 2025
bd8c7bd
Merge branch 'main' into backfill-enums/s3
mergify[bot] Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/aws-cdk-lib/aws-s3/lib/bucket.ts
View file
Original file line number Diff line number Diff line change
@@ -3292,6 +3292,21 @@ export enum EventType {
* object’s ACL.
*/
OBJECT_ACL_PUT = 's3:ObjectAcl:Put',

/**
* Using restore object event types you can receive notifications for
* initiation and completion when restoring objects from the S3 Glacier
* storage class.
*
* You use s3:ObjectRestore:* to request notification of
* any restoration event.
*/
OBJECT_RESTORE = 's3:ObjectRestore:*',

Comment on lines +3303 to +3304
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should we also add the specific enums for object restore and replication? Ref: https://docs.aws.amazon.com/AmazonS3/latest/userguide/notification-how-to-event-types-and-destinations.html#supported-notification-event-types

s3:ObjectRestore:Post
s3:ObjectRestore:Completed
s3:ObjectRestore:Delete
s3:Replication:OperationFailedReplication
s3:Replication:OperationMissedThreshold
s3:Replication:OperationReplicatedAfterThreshold
s3:Replication:OperationNotTracked

/**
* You receive this notification event for any object replication event.
*/
REPLICATION = 's3:Replication:*',
}

export interface NotificationKeyFilter {