feat(kinesisfirehose): add HTTP Endpoint and Datadog destination #33657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/medium
aws-cdk-automation
previously requested changes
Mar 1, 2025
benjaminpottier
changed the title
|
This is my first time creating a pull request for this project so any feedback is appreciated. I'm still figuring out the integration tests and have left this in draft while I work on it. |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Seemed fairly obvious after a while that an L2 for an HTTP destination should come first. Not sure if this would be the right approach to reuse it for Datadog. |
benjaminpottier
changed the title
benjaminpottier
force-pushed
the
aws-kinesisfirehose-datadog-destination
branch
from
a5f07dc to
fb42a8d
Compare
added 2 commits
March 5, 2025 10:04
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #20354 and #15502
Reason for this change
Adding support for HTTP destinations and adding Datadog as an opinionated third-party destination.
Description of changes
Adds support for using Datadog as a delivery destination for Amazon Data Firehose using an L2 HTTP endpoint destination.
Describe any new or updated permissions being added
Nothing.
Description of how you validated changes
Added unit tests. Have not yet added integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license