-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecr): lookup existing repository #33662
Open
badmintoncryer
wants to merge
17
commits into
aws:main
Choose a base branch
from
badmintoncryer:8461-lookup-ecr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
710a88e
feat: lookup ecr repository
badmintoncryer 121fd15
add validation
badmintoncryer b1df667
temp
badmintoncryer af60a3c
update integ test
badmintoncryer b31a51a
update integ
badmintoncryer 08b9fbc
restore
badmintoncryer 97edbbb
update jsdoc
badmintoncryer 1aae549
add unit test
badmintoncryer 1ab4fb8
update readme
badmintoncryer 7ee2a3a
Merge branch 'main' into 8461-lookup-ecr
badmintoncryer 473f690
fix import order
badmintoncryer e7d5229
test: add unit test
badmintoncryer 6ef1867
fix readme
badmintoncryer baef3d6
Merge branch 'main' into 8461-lookup-ecr
badmintoncryer 545e5a4
Merge branch 'main' into 8461-lookup-ecr
badmintoncryer 86f7777
add unit test
badmintoncryer ddd678b
Merge branch 'main' into 8461-lookup-ecr
badmintoncryer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix import order
- Loading branch information
commit 473f690b5e3db340070dc66abe32338addf2bc5c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test case to check if provided ECR repo (name or ARN) does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!