Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): clarifying blockPublicAccess behavior with v2 #33668

Closed
wants to merge 6 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: attempting to change type output
  • Loading branch information
Ike Nefcy committed Mar 1, 2025
commit dddd11e52804c6cff4fd6dfe463d1635a1f08f56
8 changes: 4 additions & 4 deletions packages/aws-cdk-lib/aws-s3/lib/bucket.ts
Original file line number Diff line number Diff line change
@@ -1080,17 +1080,17 @@ export interface BlockPublicAccessOptions {
* @deprecated Use `BlockPublicAccessV2` instead.
*/
export class BlockPublicAccess {
public static readonly BLOCK_ALL = new BlockPublicAccess({
public static readonly BLOCK_ALL: BlockPublicAccessOptions ={
blockPublicAcls: true,
blockPublicPolicy: true,
ignorePublicAcls: true,
restrictPublicBuckets: true,
});
};

public static readonly BLOCK_ACLS = new BlockPublicAccess({
public static readonly BLOCK_ACLS: BlockPublicAccessOptions = {
blockPublicAcls: true,
ignorePublicAcls: true,
});
};

public blockPublicAcls: boolean | undefined;
public blockPublicPolicy: boolean | undefined;