Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler-alpha): deprecate Group in favour of ScheduleGroup #33678

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

gracelu0
Copy link
Contributor

@gracelu0 gracelu0 commented Mar 3, 2025

Issue # (if applicable)

n/a

Reason for this change

The awslint rules enforce naming to be consistent with CloudFormation resources. In this case, the CFN resource is AWS::Scheduler::ScheduleGroup but the construct was named Group when it should be ScheduleGroup.

When this module is stabilized, Group will be completely removed.

Description of changes

  • Mark Group and related methods as deprecated. Deprecation
  • Introduce new class ScheduleGroup (duplicate of Group, just renamed)
  • Addressed most awslint exemptions in the module
  • Update any logic referencing group to reference scheduleGroup
  • Updated README examples

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Updated unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 3, 2025 23:30
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 3, 2025
"from-method:@aws-cdk/aws-scheduler-alpha.Schedule",
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleArn",
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleName",
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleGroup",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this exemption as scheduleGroup is not an attribute of Schedule

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@gracelu0 gracelu0 added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 3, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 3, 2025 23:32

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (4bc151b) to head (d3d5bdb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33678   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

@gracelu0 gracelu0 force-pushed the schedule-deprecate-group branch from 5801675 to c7d0aa6 Compare March 4, 2025 00:42
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 4, 2025
@shikha372 shikha372 self-assigned this Mar 4, 2025
@shikha372
Copy link
Contributor

LGTM, Thank you @gracelu0

Copy link
Contributor

mergify bot commented Mar 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 4, 2025
Copy link
Contributor

mergify bot commented Mar 4, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Mar 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d3d5bdb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4d8eae9 into aws:main Mar 5, 2025
20 checks passed
Copy link

github-actions bot commented Mar 5, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants