-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scheduler-alpha): deprecate Group
in favour of ScheduleGroup
#33678
Conversation
"from-method:@aws-cdk/aws-scheduler-alpha.Schedule", | ||
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleArn", | ||
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleName", | ||
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleGroup", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this exemption as scheduleGroup
is not an attribute of Schedule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33678 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 119 119
Lines 6876 6876
Branches 1162 1162
=======================================
Hits 5653 5653
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5801675
to
c7d0aa6
Compare
LGTM, Thank you @gracelu0 |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
n/a
Reason for this change
The
awslint
rules enforce naming to be consistent with CloudFormation resources. In this case, the CFN resource isAWS::Scheduler::ScheduleGroup
but the construct was namedGroup
when it should beScheduleGroup
.When this module is stabilized,
Group
will be completely removed.Description of changes
Group
and related methods as deprecated. DeprecationScheduleGroup
(duplicate of Group, just renamed)awslint
exemptions in the modulegroup
to referencescheduleGroup
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Updated unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license