Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler-alpha): deprecate Group in favour of ScheduleGroup #33678

Merged
merged 7 commits into from
Mar 5, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
gracelu0 committed Mar 3, 2025
commit 709094511a61c54a8c27d849f49dc971e16739b4
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-scheduler-targets-alpha/lib/target.ts
Original file line number Diff line number Diff line change
@@ -114,12 +114,12 @@ export abstract class ScheduleTargetBase {
conditions: {
StringEquals: {
'aws:SourceAccount': schedule.env.account,
'aws:SourceArn': schedule.group?.groupArn ?? Stack.of(schedule).formatArn({
'aws:SourceArn': schedule.scheduleGroup?.scheduleGroupArn ?? schedule.group?.groupArn ?? Stack.of(schedule).formatArn({
service: 'scheduler',
resource: 'schedule-group',
region: schedule.env.region,
account: schedule.env.account,
resourceName: schedule.group?.groupName ?? 'default',
resourceName: schedule.scheduleGroup?.scheduleGroupName ?? schedule.group?.groupName ?? 'default',
}),
},
},
Original file line number Diff line number Diff line change
@@ -312,7 +312,7 @@ describe('Universal schedule target', () => {
'aws:SourceAccount': '123456789012',
'aws:SourceArn': {
'Fn::GetAtt': [
'GroupC77FDACD',
'ScheduleGroup4D377372',
'Arn',
],
},
Loading
Oops, something went wrong.