Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda-nodejs): update integration test for bundling #33679

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Mar 4, 2025

Issue # (if applicable)

Closes #NA.

Reason for this change

Plan to change default user to a be non-root for bundling process.

Description of changes

  • Added integration test for all packages that use dockerfile for bundling and will be affected with further changes.
  • Added bootstrap file binary to be identified as an LFS under .gitattribute
  • Updated contributing guide to let users know that git lfs install is needed to handle large file changes.

Describe any new or updated permissions being added

NA

Description of how you validated changes

yarn build
yarn integ

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 4, 2025 00:19
@github-actions github-actions bot added the p2 label Mar 4, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 4, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (6c882e0) to head (b169227).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33679   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shikha372 shikha372 changed the title chore(aws-lambda-nodejs): update integration test for bundling chore(lambda-nodejs): update integration test for bundling Mar 4, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 4, 2025 00:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 force-pushed the shikagg/bundling-root-user branch from 3c62f35 to 8afdc75 Compare March 4, 2025 07:07
@shikha372 shikha372 marked this pull request as ready for review March 4, 2025 07:27
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 4, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b169227
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants