chore(enum-updater): add enum updater tool #33681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for static mapping matching
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33681 +/- ##
==========================================
+ Coverage 82.21% 82.24% +0.02%
==========================================
Files 119 119
Lines 6876 6875 -1
Branches 1162 1161 -1
==========================================
+ Hits 5653 5654 +1
+ Misses 1120 1118 -2
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
paulhcsun
commented
Mar 4, 2025
Comment on lines
+1
to
+9
| { | ||
| "amplify": { | ||
| "RedirectStatus": { | ||
| "cdk_path": "aws-cdk/packages/@aws-cdk/aws-amplify-alpha/lib/app.ts" | ||
| }, | ||
| "CustomRule": { | ||
| "cdk_path": "aws-cdk/packages/@aws-cdk/aws-amplify-alpha/lib/app.ts" | ||
| } | ||
| }, |
There was a problem hiding this comment.
This file is not really necessary, but I don't think it hurts to keep track of it. I'm open to removing it or keeping it for reference. It is a list of all the CDK enums that are not mapped.
aws-cdk-automation
added
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This tool currently takes in the CDK enums and SDK enums as inputs, creates a static mapping between CDK enums to SDK enums, and then identifies missing values to make code changes to add in the missing values.
Features
Implementation Details
The tool consists of two main components:
static-enum-mapping-updater.ts: Handles the downloading and processing of enum definitions, creating mappings between CDK and SDK enumsmissing-enums-updater.ts: Identifies missing enum values by referencing the static-enum-mapping and the CDK and SDK enum datasources and updates the source files.Usage
This tool will be run automatically by a weekly GitHub workflow to keep CDK enums up to date.
Description of how you validated changes
Manual + unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license