Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logs-destinations): support Amazon Data Firehose logs destination #33683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Mar 4, 2025

Issue # (if applicable)

Closes #32038.

Reason for this change

Adding support of Amazon Data Firehose destination was waiting for stabilize aws-kinesisfirehose.

Description of changes

Added the FirehoseDestination logs destination class.
Usage:

declare const logGroup: logs.LogGroup;
declare const stream: firehose.DeliveryStream;

new logs.SubscriptionFilter(stack, 'SubscriptionFilter', {
  logGroup,
  destination: new destinations.FirehoseDestination(stream),
  filterPattern: logs.FilterPattern.allEvents(),
});

Describe any new or updated permissions being added

Following permissions will be granted to a role of destination.
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/SubscriptionFilters.html#FirehoseExample

Description of how you validated changes

Unit tests and integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort star-contributor [Pilot] contributed between 25-49 PRs to the CDK feature-request A feature should be added or improved. p2 labels Mar 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 4, 2025 07:58
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (ab368ee) to head (96745ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33683   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

@Tietew Tietew force-pushed the logs-destinations-firehose branch from 6440886 to 96745ab Compare March 4, 2025 08:29
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 96745ab
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 4, 2025
@Tietew Tietew changed the title feat(logs-destinations): add support of Amazon Data Firehose destination feat(logs-destinations): support Amazon Data Firehose logs destination Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-logs-destinations: Missing FirehoseDestination or DataFirehoseDestination
2 participants