Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ec2): add VPC interface endpoints for WAFV2 #33685

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yendoooo
Copy link

@yendoooo yendoooo commented Mar 4, 2025

Issue # (if applicable)

Reason for this change

There are no VPC endpoints for AWS WAFV2 so I added.

% aws ec2 describe-vpc-endpoint-services --filters "Name=service-name,Values=*waf*" --region us-east-1 --query "ServiceNames[]" 
[
    "com.amazonaws.us-east-1.wafv2",
    "com.amazonaws.us-east-1.wafv2-fips"
]

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Mar 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 4, 2025 17:04
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 4, 2025
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 4, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (b55199a) to head (707e434).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33685   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

@shikha372 shikha372 self-assigned this Mar 5, 2025
shikha372
shikha372 previously approved these changes Mar 6, 2025
Copy link
Contributor

mergify bot commented Mar 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Mar 6, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 6, 2025
Copy link
Contributor

mergify bot commented Mar 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Contributor

@mergify update

Copy link
Contributor

mergify bot commented Mar 6, 2025

update

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • any of:
    • sender = {{author}}
    • sender-permission >= write

@badmintoncryer
Copy link
Contributor

@yendoooo Could you please make a comment @mergify update?

@yendoooo
Copy link
Author

yendoooo commented Mar 6, 2025

@mergify update

Copy link
Contributor

mergify bot commented Mar 6, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@yendoooo
Copy link
Author

yendoooo commented Mar 6, 2025

@badmintoncryer Should I merge latest main branch locally and push again?

@badmintoncryer
Copy link
Contributor

@yendoooo Let's ask the maintainer for help!

@shikha372 Could you please resolve this mergify problem?

@mergify mergify bot dismissed shikha372’s stale review March 7, 2025 02:00

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 25ce9a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants