-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event-targets): add role property to sqs event target #33701
base: main
Are you sure you want to change the base?
feat(event-targets): add role property to sqs event target #33701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33701 +/- ##
=======================================
Coverage 82.24% 82.24%
=======================================
Files 119 119
Lines 6875 6875
Branches 1161 1161
=======================================
Hits 5654 5654
Misses 1118 1118
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Reason for this change
Add role property to SQS Event Target in EventBridge
Description of changes
Add role attribute to SQS Event Target in EventBridge which is available in AWS CloudFormation template but was not available in AWS CDK.
Describe any new or updated permissions being added
No changes in permissions are made.
Description of how you validated changes
Deploy an EventBridge Rule with SQS Event Target and custom role.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license