Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build 2.24.14 in Alpine 3.20, Python 3.11.11 #9331

Closed
1 task done
isuftin opened this issue Feb 28, 2025 · 5 comments
Closed
1 task done

Unable to build 2.24.14 in Alpine 3.20, Python 3.11.11 #9331

isuftin opened this issue Feb 28, 2025 · 5 comments
Labels
bug This issue is a bug. p1 This is a high priority issue potential-regression Marking this issue as a potential regression to be checked by team member source-distribution cli v2 source distritbution related issues

Comments

@isuftin
Copy link

isuftin commented Feb 28, 2025

Describe the bug

There seems to be a regression introduced into 2.24.14 for Alpine Linux

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

awscli compiles without issue

Current Behavior

...

#10 641.8 238124 INFO: Analyzing run-time hooks ...                                                                                                                                                                                                  #10 641.8 238157 INFO: Including run-time hook 'pyi_rth_inspect.py' from '/target/build/venv/lib/python3.11/site-packages/PyInstaller/hooks/rthooks'
#10 641.9 238171 INFO: Including run-time hook 'pyi_rth_pkgutil.py' from '/target/build/venv/lib/python3.11/site-packages/PyInstaller/hooks/rthooks'
#10 641.9 238183 INFO: Including run-time hook 'pyi_rth_multiprocessing.py' from '/target/build/venv/lib/python3.11/site-packages/PyInstaller/hooks/rthooks'
#10 641.9 238197 INFO: Including run-time hook 'pyi_rth_cryptography_openssl.py' from '/target/build/venv/lib/python3.11/site-packages/_pyinstaller_hooks_contrib/rthooks'
#10 643.3 239588 INFO: Looking for dynamic libraries
#10 644.7 240996 INFO: Warnings written to /target/build/exe/build/aws/warn-aws.txt
#10 645.2 241479 INFO: Graph cross-reference written to /target/build/exe/build/aws/xref-aws.html
#10 646.4 Traceback (most recent call last):
#10 646.4   File "/target/build/venv/bin/pyinstaller", line 8, in <module>
#10 646.4     sys.exit(_console_script_run())
#10 646.4              ^^^^^^^^^^^^^^^^^^^^^
#10 646.4   File "/target/build/venv/lib/python3.11/site-packages/PyInstaller/__main__.py", line 231, in _console_script_run
#10 646.4     run()
#10 646.4   File "/target/build/venv/lib/python3.11/site-packages/PyInstaller/__main__.py", line 215, in run
#10 646.4     run_build(pyi_config, spec_file, **vars(args))
#10 646.4   File "/target/build/venv/lib/python3.11/site-packages/PyInstaller/__main__.py", line 70, in run_build
#10 646.4     PyInstaller.building.build_main.main(pyi_config, spec_file, **kwargs)
#10 646.4   File "/target/build/venv/lib/python3.11/site-packages/PyInstaller/building/build_main.py", line 1252, in main
#10 646.4     build(specfile, distpath, workpath, clean_build)
#10 646.4   File "/target/build/venv/lib/python3.11/site-packages/PyInstaller/building/build_main.py", line 1192, in build
#10 646.4     exec(code, spec_namespace)
#10 646.4   File "/target/exe/pyinstaller/aws.spec", line 41, in <module>
#10 646.4     raise ValueError((f'Symlink ({dest} -> {src}) found in table of contents. '
#10 646.4 ValueError: Symlink (libgcc_s-a3a07607.so.1 -> cryptography.libs/libgcc_s-a3a07607.so.1) found in table of contents. Our downstream packaging and signing code does not support symlinks, so this requires investigation.
#10 646.7 Traceback (most recent call last):
#10 646.7   File "<frozen runpy>", line 198, in _run_module_as_main
#10 646.7   File "<frozen runpy>", line 88, in _run_code
#10 646.7   File "/target/./backends/build_system/__main__.py", line 125, in <module>
#10 646.7     main()
#10 646.7   File "/target/./backends/build_system/__main__.py", line 121, in main
#10 646.7     parsed_args.func(parsed_args)
#10 646.7   File "/target/./backends/build_system/__main__.py", line 45, in build
#10 646.7     create_exe(aws_venv, parsed_args.build_dir)
#10 646.7   File "/target/./backends/build_system/__main__.py", line 35, in create_exe
#10 646.7     builder.build()
#10 646.7   File "/target/./backends/build_system/exe.py", line 41, in build
#10 646.7     self._build_aws()
#10 646.7   File "/target/./backends/build_system/exe.py", line 66, in _build_aws
#10 646.7     aws_exe_build_dir = self._run_pyinstaller("aws.spec")
#10 646.7                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#10 646.7   File "/target/./backends/build_system/exe.py", line 79, in _run_pyinstaller
#10 646.7     self._utils.run(                                                                                                                                                                                                                       #10 646.7   File "/target/./backends/build_system/utils.py", line 235, in run                                                                                                                                                                        #10 646.7     return subprocess.run(args, **kwargs)                                                                                                                                                                                                  #10 646.7            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                  #10 646.7   File "/usr/local/lib/python3.11/subprocess.py", line 571, in run                                                                                                                                                                         #10 646.7     raise CalledProcessError(retcode, process.args,
#10 646.7 subprocess.CalledProcessError: Command '['/target/build/venv/bin/python', '/target/build/venv/bin/pyinstaller', '/target/exe/pyinstaller/aws.spec', '--distpath', '/target/build/exe/dist', '--workpath', '/target/build/exe/build']' retur
ned non-zero exit status 1.
#10 646.7 Update metadata values {'distribution_source': 'source-sandbox'}
#10 646.8 make: *** [Makefile:20: build] Error 1
#10 ERROR: process "/bin/ash -eo pipefail -c apk add --no-cache       cmake~=3.29       curl~=8       dpkg~=1.22       g++~=13.2.1       gcc~=13.2.1       libc-dev~=1.2.5       libcrypto3~=3.3.3       libffi-dev~=3.4.6       libssl3~=3.3.3
 make~=4.4       openssl-dev~=3.3.3       openssl~=3.3.3       upx~=4     && curl -sSL https://awscli.amazonaws.com/awscli-${INSTALL_VERSION}.tar.gz | tar -xz --strip-components 1   && ./configure --with-download-deps --with-install-type=portabl
e-exe   && make && make install" did not complete successfully: exit code: 2
------
 > [4/4] RUN apk add --no-cache       cmake~=3.29       curl~=8       dpkg~=1.22       g++~=13.2.1       gcc~=13.2.1       libc-dev~=1.2.5       libcrypto3~=3.3.3       libffi-dev~=3.4.6       libssl3~=3.3.3       make~=4.4       openssl-dev~=3.
3.3       openssl~=3.3.3       upx~=4     && curl -sSL https://awscli.amazonaws.com/awscli-2.24.14.tar.gz | tar -xz --strip-components 1   && ./configure --with-download-deps --with-install-type=portable-exe   && make && make install:
646.7   File "/target/./backends/build_system/exe.py", line 79, in _run_pyinstaller
646.7     self._utils.run(
646.7   File "/target/./backends/build_system/utils.py", line 235, in run
646.7     return subprocess.run(args, **kwargs)
646.7            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
646.7   File "/usr/local/lib/python3.11/subprocess.py", line 571, in run
646.7     raise CalledProcessError(retcode, process.args,
646.7 subprocess.CalledProcessError: Command '['/target/build/venv/bin/python', '/target/build/venv/bin/pyinstaller', '/target/exe/pyinstaller/aws.spec', '--distpath', '/target/build/exe/dist', '--workpath', '/target/build/exe/build']' returned
non-zero exit status 1.
646.7 Update metadata values {'distribution_source': 'source-sandbox'}
646.8 make: *** [Makefile:20: build] Error 1

Reproduction Steps

Dockerfile:

# syntax=dockerfile:1

FROM python:3.11.11-alpine3.20

SHELL ["/bin/ash", "-eo", "pipefail", "-c"]

WORKDIR /target

# Grab install dependencies
RUN apk add --no-cache \
      cmake~=3.29 \
      curl~=8 \
      dpkg~=1.22 \
      g++~=13.2.1 \
      gcc~=13.2.1 \
      libc-dev~=1.2.5 \
      libcrypto3~=3.3.3 \
      libffi-dev~=3.4.6 \
      libssl3~=3.3.3 \
      make~=4.4 \
      openssl-dev~=3.3.3 \
      openssl~=3.3.3 \
      upx~=4 \
  \
  && curl -sSL https://awscli.amazonaws.com/awscli-2.24.14.tar.gz | tar -xz --strip-components 1 \
  && ./configure --with-download-deps --with-install-type=portable-exe \
  && make && make install
  • Edited a bunch of cruft out of reproducible steps as the error happens during make install

Possible Solution

Unknown

Additional Information/Context

No response

CLI version used

2.24.14

Environment details (OS name and version, etc.)

Alpine 3.20, Python 3.11.11

@isuftin isuftin added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2025
@github-actions github-actions bot added the potential-regression Marking this issue as a potential regression to be checked by team member label Feb 28, 2025
@ashovlin
Copy link
Member

Taking a look, this lines up with our PyInstaller upgrade via #9194 which was released in 2.24.14 yesterday.

@NamesMT
Copy link

NamesMT commented Feb 28, 2025

+1 same issue, costed me an hour trying to (unsuccessfully) finding a workaround.

@ashovlin
Copy link
Member

We've reverted the PyInstaller upgrade, which should flow out in today's release in a few hours. We'll fix and test on Alpine before rolling forward again.

@RyanFitzSimmonsAK RyanFitzSimmonsAK added p1 This is a high priority issue source-distribution cli v2 source distritbution related issues and removed needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2025
@isuftin
Copy link
Author

isuftin commented Feb 28, 2025

This fixes the build on our end. Thank you!

@isuftin isuftin closed this as completed Feb 28, 2025
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1 This is a high priority issue potential-regression Marking this issue as a potential regression to be checked by team member source-distribution cli v2 source distritbution related issues
Projects
None yet
Development

No branches or pull requests

4 participants