Lint and format awscli customizations - cloudformation, cloudtrail, codeartifact, codedeploy, configservice, configure #9161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaily
force-pushed
the
ruff-check-base-repo-customizations-nested-c
branch
2 times, most recently
from
1e25afc to
193eeb0
Compare
kdaily
force-pushed
the
ruff-check-base-repo-customizations-nested-c
branch
from
193eeb0 to
7e07719
Compare
kdaily
changed the title
kdaily
force-pushed
the
ruff-check-base-repo-customizations-nested-c
branch
from
9493f42 to
fd4aabb
Compare
kdaily
force-pushed
the
ruff-check-base-repo-customizations-nested-c
branch
from
fd4aabb to
98a9143
Compare
kdaily
commented
Mar 3, 2025
| r'(?P<option>[^:=][^:=]*)' | ||
| r'\s*(?P<vi>[:=])\s*' | ||
| r'(?P<value>.*)$' | ||
| r'(?P<option>[^:=][^:=]*)' r'\s*(?P<vi>[:=])\s*' r'(?P<value>.*)$' |
There was a problem hiding this comment.
Not a fan of this, but see the value in separating the lines of the long regex. Suggest skipping formatting here (add # fmt: skip).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #9161 +/- ##
==========================
==========================
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.