-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced /mybucket/ with amzn-s3-demo-bucket #9220
Replaced /mybucket/ with amzn-s3-demo-bucket #9220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sending for maintainer review.
Due to other recently merged PRs, these have some conflicts to fix. |
Update merged. |
@DavidSouther - thanks for the update, and apologies for the delay in getting the tests to re-run; when there are force pushes GitHub does not always force the test suite to re-run. Unfortunately the changes have some formatting errors - you can see in the test suite, but they look like:
https://github.com/aws/aws-cli/actions/runs/13550995902/job/37874307218?pr=9220#step:5:521 |
b8deb99
to
2935fc0
Compare
Oops, I missed your comment about force pushes not reruning tests. I typically do squash-rebase PRs to keep them tidy. Updated to latest tip, but that error looks spurious to me - the block has the same indentation and formatting as previously, and the block shouldn't be checking for inline styles? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9220 +/- ##
=======================================
Coverage 0.08% 0.08%
=======================================
Files 210 210
Lines 16984 16984
=======================================
Hits 14 14
Misses 16970 16970 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Strange, just ran the tests locally and they passed. I just approved the GitHub CI to run again so hopefully everything is good now. Thanks! |
Waiting for tests to pass on the CLI v2 port of this PR: #9347 |
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.