Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI examples ecs, cognito-idp #9312

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

elysahall
Copy link
Collaborator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elysahall elysahall added documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member. labels Feb 21, 2025
@elysahall elysahall requested a review from aemous February 21, 2025 18:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.08%. Comparing base (96f96b8) to head (4b2e32d).
Report is 73 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #9312   +/-   ##
=======================================
  Coverage     0.08%   0.08%           
=======================================
  Files          210     210           
  Lines        16984   16984           
=======================================
  Hits            14      14           
  Misses       16970   16970           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@aemous aemous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Requested some minor changes, and some suggestions/nits.

Copy link
Contributor

@aemous aemous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one minor nit and this should be ready to merge

@@ -1,9 +1,11 @@
**Example 1: To create a new cluster**

The following ``create-cluster`` example creates a cluster. ::
The following ``create-cluster`` example creates a cluster named ``MyCluster`` and uses enables CloudWatch Container Insights with enhanced observability. ::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uses enables" -> "uses" (or "enables")

@AMZ-brandon
Copy link

Cognito dev guide author here. Regarding those changes to the cognito-idp examples, I crafted the syntax so that it would run on my Linux zsh. For example, copy-pasting the revised string --query 'Users[*].Attributes[?Value.contains(@,"@amazon.com")]' returns

'in <string>' requires string as left operand, not NoneType

My original version with the escape characters returns the expected results. This is true for other cases where escape characters appear.

@elysahall elysahall force-pushed the awsdocs-02-05-25 branch 2 times, most recently from debb005 to 8e99fb6 Compare March 5, 2025 21:50
Copy link
Contributor

@aemous aemous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change with a command's shorthand syntax and this is ready to merge

@aemous aemous self-requested a review March 7, 2025 15:56
Copy link
Contributor

@aemous aemous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Mar 7, 2025
2 tasks
@aemous aemous merged commit 770d797 into aws:develop Mar 7, 2025
30 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Mar 7, 2025
* release-1.38.9:
  Bumping version to 1.38.9
  Update changelog based on model updates
  CLI examples ecs, cognito-idp (#9312)
  Update get-merge-commit.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants