-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI examples ecs, cognito-idp #9312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9312 +/- ##
=======================================
Coverage 0.08% 0.08%
=======================================
Files 210 210
Lines 16984 16984
=======================================
Hits 14 14
Misses 16970 16970 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Requested some minor changes, and some suggestions/nits.
081fa2c
to
bfd408d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, one minor nit and this should be ready to merge
@@ -1,9 +1,11 @@ | |||
**Example 1: To create a new cluster** | |||
|
|||
The following ``create-cluster`` example creates a cluster. :: | |||
The following ``create-cluster`` example creates a cluster named ``MyCluster`` and uses enables CloudWatch Container Insights with enhanced observability. :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"uses enables" -> "uses" (or "enables")
Cognito dev guide author here. Regarding those changes to the cognito-idp examples, I crafted the syntax so that it would run on my Linux zsh. For example, copy-pasting the revised string
My original version with the escape characters returns the expected results. This is true for other cases where escape characters appear. |
debb005
to
8e99fb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change with a command's shorthand syntax and this is ready to merge
8e99fb6
to
4b2e32d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* release-1.38.9: Bumping version to 1.38.9 Update changelog based on model updates CLI examples ecs, cognito-idp (#9312) Update get-merge-commit.rst
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.