Revert "Bump pyinstaller from 5.13.2 to 6.11.1 (#9194)" #9332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 875b33f.
hssyoo
approved these changes
Feb 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #9332 +/- ##
==========================
==========================
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #9331
Description of changes:
This reverts the PyInstaller 6 upgrade via commit 875b33f.
While upgrading to PyInstaller 6, we added a verification step during the installer build to ensure that there are no symlinks found in the bundle. Our internal build + Mac signing system didn't handle these well, so we were ending up with duplicate files.
However, building on Alpine does produce a symlink
libgcc_s-7393e603.so.1 -> cryptography.libs/libgcc_s-7393e603.so.1.We should investigate that the Alpine build works after the upgrade, and possibly running that validation only for Mac, but reverting initially to allow time to investigate.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.