Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] User agent 2.1: Track client features #9333

Merged
merged 8 commits into from
Mar 4, 2025
Merged

[v2] User agent 2.1: Track client features #9333

merged 8 commits into from
Mar 4, 2025

Conversation

hssyoo
Copy link
Contributor

@hssyoo hssyoo commented Feb 28, 2025

Ports boto/botocore#3389 and boto/s3transfer#335

I also added a CLI-specific change to wrap the CLI entrypoint under the start_as_current_context context manager so future work can add CLI-specific features.

> aws s3 cp myfile s3://mybucket
> aws history show

...
"User-Agent": "aws-cli/2.24.14 ... m/G cfg/retry-mode#standard ..."
...

@hssyoo hssyoo requested a review from ashovlin February 28, 2025 18:58
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. For the S3 high-level commands, can we track the HeadObject calls too (unless the internal design says not to)?

@hssyoo
Copy link
Contributor Author

hssyoo commented Mar 4, 2025

Changes look good. For the S3 high-level commands, can we track the HeadObject calls too (unless the internal design says not to)?

Addressed in 35e6716

I considered only registering at the point of HeadObject/ListObjectsV2 calls (code), but decided to just move it under S3TransferCommand so that we consider any API calls made in this class of commands to have used S3Transfer.

@hssyoo hssyoo merged commit 3e53394 into v2 Mar 4, 2025
86 of 90 checks passed
@hssyoo hssyoo deleted the ua-2.1 branch March 4, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants