Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Account ID Endpoint Mode for Unsigned Requests #9334

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AndrewAsseily
Copy link
Contributor

Issue #, if available: CLI-5255

Description of changes:

  • Disabled account ID based endpoint routing when handling unsigned requests.
  • Updated test to verify the CLI properly updates the client config to use unsigned requests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.08%. Comparing base (96f96b8) to head (f43ca34).
Report is 54 commits behind head on develop.

Files with missing lines Patch % Lines
awscli/customizations/globalargs.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #9334   +/-   ##
=======================================
  Coverage     0.08%   0.08%           
=======================================
  Files          210     210           
  Lines        16984   16983    -1     
=======================================
  Hits            14      14           
+ Misses       16970   16969    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks okay. Please dry-run internally first since we have some integ tests covering --no-sign-request that GitHub Actions won't exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants