[ec2-instance-connect] add more cleanup to websockets #9346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #9344
Description of changes: Adds a lot of additional handling to ensure websockets get closed once the processes pipes get closed so that the process can exit. I was using
aws ec2-instance-connect open-tunnelin conjunction with changes made to Terraform to allow using it as a process to pipe its SSH connections through (see hashicorp/terraform#36643). However in that usage without explicitly sending it a hangup signal, the aws process will continue running with websockets still open. I tested this PR's changes without sending the process explicit signals on the Terraform side and it worked as the aws process exited successfully when the its pipes were closed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.