-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: editable dependencies in Python breaks build command #818
Comments
I ran into this today too. |
Ditto. I ran into this when building from a privately hosted repository.
so uber-sad :(
|
This has been sitting open for close to 2 years.. |
Yeah...time to invest some time and fix? :D |
That's critical! How to work around it? |
I'd say that one approach to deal with that could be putting something you PS. IMHO because I haven't tested that. It just seems reasonable to assume that. |
This might be the workaround: |
I would like to point out another possible scenario that could result into For example: The project upgraded the whole set of dependencies, but one of them comes with a recently discovered error in the context of your system. At this point it might be that you can not downgrade a version because your database or other set of dependencies was already upgraded. Given that is already being used in prod, you need to take more actions after reporting the issue because your system needs to keep going. If the dependency project is slow to fix regressions:
It is advisable to do that, just in case that you have knowledge of over the dependency project (for example, you belong to its development community). Interesting from this case... is that the repository might even public, so it doesn't need credentials... but you would still get the error: `OSError: [Errno 30] Read-only file system: '/tmp/samcli/source/src' The error is related more to the editable nature of the dependency deployment than to the private nature of the repository. What I mean is that somehow this discussion has been deviated from the former to the later. The original problem was not related to specify the credentials of the private repository, it was related to the read-only nature of the path were the editable dependency is going to be installed to. It can also happen in public code that doesn't need authentication. Am I missing something ? Or still more work is needed here ? |
Currently,
sam build
uses a requirements.txt file to install dependancies, if a dep is marked as editable (-e in the file), it causes thebuild
command to break with:OSError: [Errno 30] Read-only file system: '/tmp/samcli/source/src'
This could potentially causes issues in a number of situations, most notably, people who use the same requirements.txt file for development and for build.
Ideally,
sam build
would strip/sanitise the requirements.txt to remove any flags for the build command.SAM CLI Version: 0.8.0
The text was updated successfully, but these errors were encountered: