Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to delete old versions when successful deployment #7414

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Adds support to delete old versions when successful deployment #7414

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
30c7fb4
Adds support to delete old versions when successful deployment
driverpt Aug 27, 2024
8e51ff7
Fetch AutoDeleteOldAlias from Metadata instead of Properties
driverpt Nov 1, 2024
6d8882d
Address PR Comments
driverpt Nov 1, 2024
94bc1e4
Fix Formatting
driverpt Nov 8, 2024
8e02b00
Apply PR Suggestion
driverpt Jan 17, 2025
3a70d2a
Make Linter Happy :)
driverpt Jan 30, 2025
1ccde56
Merge branch 'develop' into add-auto-delete-old-version
seshubaws Feb 17, 2025
7c2c25b
Merge branch 'develop' into add-auto-delete-old-version
seshubaws Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply PR Suggestion 
Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
  • Loading branch information
@driverpt @mndeveci
driverpt and mndeveci committed Jan 30, 2025
commit 8e02b00a1f2af2dbd3fa918938424f0a20ebeac5
8 changes: 3 additions & 5 deletions samcli/lib/sync/flows/alias_version_sync_flow.py
View file
Original file line number Diff line number Diff line change
@@ -118,10 +118,8 @@ def _equality_keys(self) -> Any:

def _get_version_alias_if_exists(self) -> Optional[str]:
try:
return str(
self._lambda_client.get_alias(
FunctionName=self.get_physical_id(self._function_identifier), Name=self._alias_name
).get("FunctionVersion")
)
return self._lambda_client.get_alias(
FunctionName=self.get_physical_id(self._function_identifier), Name=self._alias_name
).get("FunctionVersion")
except self._lambda_client.exceptions.ResourceNotFoundException:
return None