Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python 3.8 support #7908

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Remove python 3.8 support #7908

wants to merge 5 commits into from

Conversation

mbfreder
Copy link
Contributor

Remove python 3.8 support

Which issue(s) does this change fix?

Why is this change necessary?

Python 3.8 is deprecated

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mbfreder mbfreder requested a review from a team as a code owner February 28, 2025 01:14
@github-actions github-actions bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke area/schema JSON schema file pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Feb 28, 2025
@mbfreder mbfreder force-pushed the remove-python-38 branch 2 times, most recently from eca5325 to 5db51c6 Compare February 28, 2025 08:08
@roger-zhangg
Copy link
Member

tests/functional/commands/init/test_interactive_init_flow.py::TestInteractiveFlow::test_unknown_runtime This is consantly failing, seems a valid bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/schema JSON schema file pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbfreder @roger-zhangg @seshubaws