Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update Ruby version in integ tests #7916

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

valerena
Copy link
Contributor

@valerena valerena commented Mar 5, 2025

  • Ruby 3.2.4 to 3.2.7
  • Ruby 3.3.4 to 3.3.7

Which issue(s) does this change fix?

Failures related to Ruby on SAM CLI integration tests environment (AppVeyor)

Why is this change necessary?

To fix the integration tests.

How does it address the issue?

It uses a version of Ruby installed on the AppVeyor hosts.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Ruby 3.2.4 to 3.2.7
- Ruby 3.3.4 to 3.3.7
@valerena valerena requested a review from a team as a code owner March 5, 2025 06:06
Copy link
Member

@roger-zhangg roger-zhangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valerena valerena enabled auto-merge March 5, 2025 18:12
@valerena valerena added this pull request to the merge queue Mar 5, 2025
Merged via the queue into aws:develop with commit 6bb45b1 Mar 5, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants