test: fix error message in 'validate' #7920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cfn-lint` changed their message when a Lambda runtime is deprecated [1] From `Check if EOL Lambda Function Runtimes are used` To `Validate if lambda runtime is deprecated` And also using nodejs16.x changed from a warning (W2531) to an error (E2531) [1]: aws-cloudformation/cfn-lint@31783ca#diff-3e96ba21727bba3d7bfb0c5c235a0cbc45eca97819429104d7ff9fbec8aa05b2
rachdry
approved these changes
Mar 5, 2025
roger-zhangg
approved these changes
Mar 5, 2025
|
just curious, is there a ticket associated with this? Or did we just see the change? |
I noticed it was the reason why some of our AppVeyor integration tests were failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfn-lintchanged their message when a Lambda runtime is deprecated 1From
Check if EOL Lambda Function Runtimes are usedTo
Validate if lambda runtime is deprecatedAnd also using nodejs16.x changed from a warning (W2531) to an error (E2531)
Also, removed some extra escape characters that were not required.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.