Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC Compiler error due to missing chrono include in Queues.h #3333

Closed
1 task
Ukilele opened this issue Mar 7, 2025 · 5 comments
Closed
1 task

MSVC Compiler error due to missing chrono include in Queues.h #3333

Ukilele opened this issue Mar 7, 2025 · 5 comments
Labels
bug This issue is a bug.

Comments

@Ukilele
Copy link

Ukilele commented Mar 7, 2025

Describe the bug

In MSVC version 193 everything works fine. But when upgrading to MSVC version 194 (e.g. Visual Studio 17.13.2), then a compiler error is emitted when including Queues.h and compiling.

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

I expect the file to compile using MSVC 194.

Current Behavior

Compiler error

Reproduction Steps

The issue arises when compiling the aws-sdk-cpp.

Possible Solution

Add #include <chrono>

Additional Information/Context

No response

AWS CPP SDK version used

1.11.352

Compiler and Version used

Visual Studio 17.13.2

Operating System and version

Windows 11

@Ukilele Ukilele added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 7, 2025
@sbiscigl
Copy link
Contributor

sbiscigl commented Mar 7, 2025

when including Queues.h and compiling

When you say Queues.hwhat file are you referring to? i dont see any file called that in the SDK.

@sbiscigl sbiscigl added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 7, 2025
@Ukilele
Copy link
Author

Ukilele commented Mar 7, 2025

I am sorry for the inprecise description. I am referring to https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-queues/include/aws/queues/Queue.h

@sbiscigl sbiscigl removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Mar 7, 2025
@sbiscigl
Copy link
Contributor

sbiscigl commented Mar 7, 2025

should be fixed now, resolving. In the future feel free to open pull requests for stuff like this. give a shout if you see something that doesnt work!

@sbiscigl sbiscigl closed this as completed Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@Ukilele
Copy link
Author

Ukilele commented Mar 9, 2025

Awesome, thanks a lot @sbiscigl !

Just FYI: Here is the changelog of MSVC: https://devblogs.microsoft.com/cppblog/whats-new-for-c-developers-in-visual-studio-2022-17-13/
And this is the PR which moved system_clock: microsoft/STL#5105 and let to the error I ran into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants