Refactor how generated model setters/getters are generated #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
changed the title
sbiscigl
approved these changes
Mar 11, 2025
| { | ||
| } | ||
|
|
||
| ###set($useRequiredField = true) |
There was a problem hiding this comment.
nit removed if commented out
SergeyRyabinin
added a commit
that referenced
this pull request
Mar 11, 2025
SergeyRyabinin
force-pushed
the
sr/modelShrinkage
branch
from
85b9f02 to
f698e3c
Compare
SergeyRyabinin
added a commit
that referenced
this pull request
Mar 11, 2025
sbera87
approved these changes
Mar 12, 2025
SergeyRyabinin
added a commit
that referenced
this pull request
Mar 12, 2025
SergeyRyabinin
force-pushed
the
sr/modelShrinkage
branch
from
a312b63 to
33f0a1b
Compare
SergeyRyabinin
added a commit
that referenced
this pull request
Mar 12, 2025
SergeyRyabinin
force-pushed
the
sr/modelShrinkage
branch
from
5d7a012 to
b7ae3ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
duplicated items in headers and documentation
Both changes are backward compatible (before: functions were explicitly declared as inline headers-only, after: functions are declared as perfect forwarding template functions).
Description of changes:
this change reduces generated documentation size from
333,061 items, totalling 13.0 GB
to
332,822 items, totalling 10.1 GB
The generated documentation would also look prettier:
vs existing
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.