add test that verifies SRA order of operations #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Mar 3, 2025
lucix-aws
force-pushed
the
middleware-order-test
branch
from
065f2cb to
0ae5808
Compare
Madrigal
approved these changes
Mar 3, 2025
|
|
||
| private GoWriter.Writable renderTest(String operationName) { | ||
| return goTemplate(""" | ||
| $1D $2D $3D $4D $5D $6D |
There was a problem hiding this comment.
man I love that we can just import things and then let Go fmt sort things later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middleware snapshot tests, on their own, are not sufficient to prevent regressions, because a snapshot test only displays and tracks changes to a state, it does not catch when changes to that state are incorrect. To address this gap, we are implementing a new new test that verifies correct operation ordering.
[internal: addresses AI 2349272]