Add credential refresh retry test #3029
Merged
+266
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
reviewed
Mar 4, 2025
| } | ||
| mhttp := &mockHTTP{ | ||
| resps: []*http.Response{ | ||
| {StatusCode: 500, Body: http.NoBody}, |
There was a problem hiding this comment.
it's interesting to me that we retry by default on 500. I guess this is because of high availability in services?
| @@ -56,6 +62,9 @@ type Options struct { | |||
| // used over the deprecated EndpointResolver. | |||
| EndpointResolverV2 EndpointResolverV2 | |||
|
|
|||
| // Signature Version 4 (SigV4) Signer | |||
| HTTPSignerV4 HTTPSignerV4 | |||
There was a problem hiding this comment.
Do we actually need to have a full auth scheme and v4 signer to test credentials refresh? Would this still work if we had static credentials?
There was a problem hiding this comment.
There's no credentials provider in options without sigv4 or sigv4a (note how the diff shows it was added here)
Madrigal
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "credential refresh" test in the kitchensink service, that explicitly verifies that credentials are re-retrieved when an operation retries.