Remove the obsolete ReadWriteTimeout property from ClientConfig all targets except .NET Framework 4.7.2 (#3683)

Author: normj

generator/.DevConfigs/90F61D8B-19CF-44D7-9373-852DF37452DC.json

@@ -0,0 +1,9 @@
+{
+    "core": {
+      "changeLogMessages": [
+        "Remove the obsolete ReadWriteTimeout property from ClientConfig all targets except .NET Framework 4.7.2."
+      ],
+      "type": "patch",
+      "updateMinimum": true
+    }
+}

sdk/src/Core/Amazon.Runtime/ClientConfig.cs

@@ -82,7 +82,6 @@ public abstract partial class ClientConfig : IClientConfig
         private bool? useFIPSEndpoint;
         private bool? disableRequestCompression;
         private long? requestMinCompressionSizeBytes;
-        private TimeSpan? readWriteTimeout = null;
         private bool disableHostPrefixInjection = false;
         private bool? endpointDiscoveryEnabled = null;
         private bool? ignoreConfiguredEndpointUrls;
@@ -1133,6 +1132,9 @@ public int HttpClientCacheSize
         }
 #endif
 
+#if NETFRAMEWORK
+        private TimeSpan? readWriteTimeout = null;
+
         /// <summary>
         /// Overrides the default read-write timeout value.
         /// </summary>
@@ -1145,9 +1147,6 @@ public int HttpClientCacheSize
         /// <exception cref="System.ArgumentOutOfRangeException">The timeout specified is less than or equal to zero and is not Infinite.</exception>
         /// </remarks>
         /// <seealso cref="P:System.Net.HttpWebRequest.ReadWriteTimeout"/>
-#if NETSTANDARD
-        [Obsolete("ReadWriteTimeout is not consumed in asynchronous HTTP requests. Please use a cancellation token to handle stream read/write timeouts.")]
-#endif
         public TimeSpan? ReadWriteTimeout
         {
             get { return this.readWriteTimeout; }
@@ -1157,6 +1156,7 @@ public TimeSpan? ReadWriteTimeout
                 this.readWriteTimeout = value;
             }
         }
+#endif
 
         /// <summary>
         /// Gets and sets of the EndpointProvider property.

sdk/src/Services/Glacier/Custom/AmazonGlacierConfig.Extensions.cs

@@ -34,9 +34,9 @@ protected override void Initialize()
             // Set Timeout and ReadWriteTimeout for Glacier client to max timeout as per-request  
             // timeouts are not supported.
             this.Timeout = ClientConfig.MaxTimeout;
-#pragma warning disable CS0612,CS0618
+#if NETFRAMEWORK
             this.ReadWriteTimeout = ClientConfig.MaxTimeout;
-#pragma warning restore CS0612,CS0618
+#endif
 #endif
             base.Initialize();
         }

sdk/src/Services/IoTJobsDataPlane/Custom/AmazonIoTJobsDataPlaneConfig.cs

@@ -36,9 +36,9 @@ protected override void Initialize()
             // Set Timeout and ReadWriteTimeout for Amazon IoTJobsDataPlane service to max timeout as per-request
             // timeouts are not supported.
             this.Timeout = ClientConfig.MaxTimeout;
-#pragma warning disable CS0612,CS0618
+#if NETFRAMEWORK
             this.ReadWriteTimeout = ClientConfig.MaxTimeout;
-#pragma warning restore CS0612,CS0618
+#endif
 #endif
         }
     }

sdk/src/Services/KinesisVideoArchivedMedia/Custom/AmazonKinesisVideoArchivedMediaConfig.cs

@@ -36,9 +36,9 @@ protected override void Initialize()
             // Set Timeout and ReadWriteTimeout for Amazon KinesisVideoArchivedMedia service to max timeout as per-request
             // timeouts are not supported.
             this.Timeout = ClientConfig.MaxTimeout;
-#pragma warning disable CS0612,CS0618
+#if NETFRAMEWORK
             this.ReadWriteTimeout = ClientConfig.MaxTimeout;
-#pragma warning restore CS0612, CS0618
+#endif
 #endif
         }
     }

sdk/src/Services/KinesisVideoMedia/Custom/AmazonKinesisVideoMediaConfig.cs

@@ -36,9 +36,9 @@ protected override void Initialize()
             // Set Timeout and ReadWriteTimeout for Amazon KinesisVideoMedia service to max timeout as per-request
             // timeouts are not supported.
             this.Timeout = ClientConfig.MaxTimeout;
-#pragma warning disable CS0612,CS0618
+#if NETFRAMEWORK
             this.ReadWriteTimeout = ClientConfig.MaxTimeout;
-#pragma warning restore CS0612,CS0618
+#endif
 #endif
         }
     }

sdk/src/Services/MediaStoreData/Custom/AmazonMediaStoreDataConfig.cs

@@ -36,9 +36,9 @@ protected override void Initialize()
             // Set Timeout and ReadWriteTimeout for Amazon MediaStoreData service to max timeout as per-request
             // timeouts are not supported.
             this.Timeout = ClientConfig.MaxTimeout;
-#pragma warning disable CS0612, CS0618
+#if NETFRAMEWORK
             this.ReadWriteTimeout = ClientConfig.MaxTimeout;
-#pragma warning restore CS0612, CS0618
+#endif
 #endif
         }
     }

sdk/src/Services/S3/Custom/AmazonS3Config.cs

@@ -265,9 +265,9 @@ protected override void Initialize()
             // Set Timeout and ReadWriteTimeout for S3 to max timeout as per-request
             // timeouts are not supported.
             this.Timeout = ClientConfig.MaxTimeout;
-#pragma warning disable CS0612,CS0618
+#if NETFRAMEWORK
             this.ReadWriteTimeout = ClientConfig.MaxTimeout;
-#pragma warning restore CS0612, CS0618
+#endif
 #endif
         }